fix: ssr invalid url

ccontrols · Oct 18, 2020 · aa7b5a2 · aa7b5a2
1 parent e7a36ab
commit aa7b5a2
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 25 deletions.
diff --git a/ui/blocks/src/PageContainer/PageContainer.tsx b/ui/blocks/src/PageContainer/PageContainer.tsx
@@ -47,13 +47,18 @@ export const PageContainer: FC<PageContainerProps> = forwardRef(
       const parseURLHash = () => {
         try {
           const url = getURL();
-          const scrollId = url.hash ? url.hash.substring(1) : undefined;
-          if (scrollId) {
-            const element = document.getElementById(scrollId);
-            if (element) {
-              setTimeout(() => {
-                element.scrollIntoView({ behavior: 'smooth', block: 'start' });
-              }, 100);
+          if (url) {
+            const scrollId = url.hash ? url.hash.substring(1) : undefined;
+            if (scrollId) {
+              const element = document.getElementById(scrollId);
+              if (element) {
+                setTimeout(() => {
+                  element.scrollIntoView({
+                    behavior: 'smooth',
+                    block: 'start',
+                  });
+                }, 100);
+              }
             }
           }
         } catch (err) {}

diff --git a/ui/blocks/src/PropsTable/controlsActions.ts b/ui/blocks/src/PropsTable/controlsActions.ts
@@ -86,17 +86,19 @@ export const useControlsActions = (props: UseControlsActionsProps) => {
       onClick: () => {
         if (controls) {
           const url = getURL();
-          const parsedParams = queryString.parse(url.search);
-          const values = getControlValues(controls);
-          parsedParams.controls = JSON.stringify(values);
-          const strValues = queryString.stringify(parsedParams);
-          const copyURL = `${url.protocol}//${url.host}${url.pathname}${
-            strValues ? `?${strValues}` : ''
-          }${url.hash ? `#${url.hash}` : ''}`;
-          copy(copyURL);
-          if (typeof window !== 'undefined') {
-            setURLCopied(true);
-            window.setTimeout(() => setURLCopied(false), 1500);
+          if (url) {
+            const parsedParams = queryString.parse(url.search);
+            const values = getControlValues(controls);
+            parsedParams.controls = JSON.stringify(values);
+            const strValues = queryString.stringify(parsedParams);
+            const copyURL = `${url.protocol}//${url.host}${url.pathname}${
+              strValues ? `?${strValues}` : ''
+            }${url.hash ? `#${url.hash}` : ''}`;
+            copy(copyURL);
+            if (typeof window !== 'undefined') {
+              setURLCopied(true);
+              window.setTimeout(() => setURLCopied(false), 1500);
+            }
           }
         }
       },

diff --git a/ui/blocks/src/context/BlockContext.tsx b/ui/blocks/src/context/BlockContext.tsx
@@ -14,11 +14,13 @@ export const BlockContextProvider: React.FC<StateRootProps &
 }) => {
   const values = useMemo(() => {
     const url = getURL();
-    const parsedParams = queryString.parse(url.search);
-    if (typeof parsedParams.controls === 'string') {
-      return typeof parsedParams.controls === 'string'
-        ? JSON.parse(parsedParams.controls)
-        : parsedParams.controls;
+    if (url) {
+      const parsedParams = queryString.parse(url.search);
+      if (typeof parsedParams.controls === 'string') {
+        return typeof parsedParams.controls === 'string'
+          ? JSON.parse(parsedParams.controls)
+          : parsedParams.controls;
+      }
     }
     return undefined;
   }, []);

diff --git a/ui/blocks/src/utils/url.ts b/ui/blocks/src/utils/url.ts
@@ -6,6 +6,6 @@ export const getURL = () => {
       ? window.parent.location.href
       : typeof document !== 'undefined'
       ? document.location.href
-      : '') || '';
-  return new URL(pageURL);
+      : undefined) || undefined;
+  return pageURL ? new URL(pageURL) : undefined;
 };