chore: move declaration modifiers

ccontrols · Jul 15, 2021 · a59b3d3 · a59b3d3
1 parent 7ca0098
commit a59b3d3
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 20 deletions.
diff --git a/misc/structured-types/src/SymbolParser.ts b/misc/structured-types/src/SymbolParser.ts
@@ -38,6 +38,7 @@ import {
   ISymbolParser,
   getInitializer,
   typeKind,
+  declarationModifiers,
 } from './ts-utils';
 import {
   cleanJSDocText,
@@ -510,26 +511,8 @@ export class SymbolParser implements ISymbolParser {
 
       const declaration = symbolDeclaration;
 
-      if ((declaration as ts.ParameterDeclaration).questionToken) {
-        prop.optional = true;
-      }
-      if (declaration?.modifiers) {
-        for (const m of declaration.modifiers) {
-          if (m.kind === ts.SyntaxKind.PrivateKeyword) {
-            prop.visibility = 'private';
-          } else if (m.kind === ts.SyntaxKind.ProtectedKeyword) {
-            prop.visibility = 'protected';
-          } else if (m.kind === ts.SyntaxKind.PublicKeyword) {
-            prop.visibility = 'public';
-          } else if (m.kind === ts.SyntaxKind.StaticKeyword) {
-            prop.static = true;
-          } else if (m.kind === ts.SyntaxKind.ReadonlyKeyword) {
-            prop.readonly = true;
-          } else if (m.kind === ts.SyntaxKind.AbstractKeyword) {
-            prop.abstract = true;
-          }
-        }
-      }
+      declarationModifiers(prop, declaration);
+
       if (declaration) {
         prop.displayName = getDeclarationName(declaration);
       }

diff --git a/misc/structured-types/src/ts-utils.ts b/misc/structured-types/src/ts-utils.ts
@@ -309,6 +309,35 @@ export const getInitializer = (
 type NodeCallback = (m: ts.PropertyDeclaration) => boolean;
 type NodeFind = (callback: NodeCallback) => ts.PropertyDeclaration | undefined;
 
+export const declarationModifiers = (
+  prop: PropType,
+  declaration?: ts.Declaration,
+): PropType => {
+  if (declaration) {
+    if ((declaration as ts.ParameterDeclaration).questionToken) {
+      prop.optional = true;
+    }
+    if (declaration.modifiers) {
+      for (const m of declaration.modifiers) {
+        if (m.kind === ts.SyntaxKind.PrivateKeyword) {
+          prop.visibility = 'private';
+        } else if (m.kind === ts.SyntaxKind.ProtectedKeyword) {
+          prop.visibility = 'protected';
+        } else if (m.kind === ts.SyntaxKind.PublicKeyword) {
+          prop.visibility = 'public';
+        } else if (m.kind === ts.SyntaxKind.StaticKeyword) {
+          prop.static = true;
+        } else if (m.kind === ts.SyntaxKind.ReadonlyKeyword) {
+          prop.readonly = true;
+        } else if (m.kind === ts.SyntaxKind.AbstractKeyword) {
+          prop.abstract = true;
+        }
+      }
+    }
+  }
+  return prop;
+};
+
 const findFileNode = (node: ts.Node): ts.SourceFile | undefined => {
   if (ts.isSourceFile(node)) {
     return node;