fix: hide blocks that have no content

ccontrols · Apr 16, 2020 · 7885080 · 7885080
1 parent 9dc671c
commit 7885080
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/ui/blocks/src/BlockContainer/components/ComponentsBlockContainer.tsx b/ui/blocks/src/BlockContainer/components/ComponentsBlockContainer.tsx
@@ -48,7 +48,7 @@ export const ComponentsBlockContainer: FC<ComponentsBlockContainerProps> = ({
       {(component, props, otherProps) => children(component, props, otherProps)}
     </ComponentsContainer>
   );
-  return (
+  return block ? (
     <BlockContainer
       title={title}
       collapsible={collapsible}
@@ -57,5 +57,5 @@ export const ComponentsBlockContainer: FC<ComponentsBlockContainerProps> = ({
     >
       {block}
     </BlockContainer>
-  );
+  ) : null;
 };
diff --git a/ui/blocks/src/BlockContainer/story/StoryBlockContainer.tsx b/ui/blocks/src/BlockContainer/story/StoryBlockContainer.tsx
@@ -39,7 +39,7 @@ export const StoryBlockContainer: FC<StoryBlockContainerProps> = ({
     title: userTitle,
   });
   const block = children(context, rest);
-  return (
+  return block ? (
     <BlockContainer
       title={title}
       collapsible={collapsible}
@@ -48,5 +48,5 @@ export const StoryBlockContainer: FC<StoryBlockContainerProps> = ({
     >
       {block}
     </BlockContainer>
-  );
+  ) : null;
 };
diff --git a/ui/blocks/src/PropsTable/PropsTable.tsx b/ui/blocks/src/PropsTable/PropsTable.tsx
@@ -39,8 +39,12 @@ export const PropsTable: FC<PropsTableProps> = ({
         if (!info) {
           return null;
         }
+        const keys = Object.keys(info.props);
+        if (!keys.length) {
+          return null;
+        }
         const parents = new Set();
-        const rows = Object.keys(info.props).map(key => {
+        const rows = keys.map(key => {
           const prop = info.props[key];
           const parentName = prop.parentName ?? '-';
           parents.add(parentName);