fix: ts-jest memory leak

ccontrols · Apr 18, 2021 · 71f714d · 71f714d
1 parent 48423e7
commit 71f714d
Show file tree

Hide file tree

Showing 25 changed files with 115 additions and 59 deletions.
diff --git a/core/jest-extract/package.json b/core/jest-extract/package.json
@@ -36,11 +36,11 @@
   "dependencies": {
     "@component-controls/core": "^3.6.3",
     "@component-controls/logger": "^2.10.4",
-    "babel-jest": "^26.4.4",
+    "babel-jest": "^26.6.3",
     "fastq": "^1.11.0",
     "jest": "^26.4.2",
     "path": "^0.12.7",
-    "ts-jest": "^26.4.4"
+    "ts-jest": "^26.5.5"
   },
   "devDependencies": {
     "@babel/preset-env": "^7.13.10",
@@ -60,11 +60,15 @@
     "Atanas Stoyanov"
   ],
   "jest": {
-    "preset": "ts-jest",
     "transform": {
       "^.+\\.(ts|tsx)?$": "ts-jest",
       "^.+\\.(js|jsx)$": "babel-jest"
     },
+    "globals": {
+      "ts-jest": {
+        "isolatedModules": true
+      }
+    },
     "roots": [
       "./test"
     ]

diff --git a/core/jest-extract/src/run-tests.ts b/core/jest-extract/src/run-tests.ts
@@ -50,7 +50,7 @@ const runTestsWorker: fastq.asyncWorker<
       {
         rootDir: projectFolder,
         testRegex: testFiles,
-        maxWorkers: 1,
+        forceExit: true,
         testPathIgnorePatterns: ['/node_modules/', '/__snapshots__/'],
         silent: true,
         verbose: false,

diff --git a/core/jest-extract/test/fixtures/simple/__jest-tmp-1/jest.config.js b/core/jest-extract/test/fixtures/simple/__jest-tmp-1/jest.config.js
diff --git a/core/jest-extract/test/fixtures/simple/__jest-tmp-2/jest.config.js b/core/jest-extract/test/fixtures/simple/__jest-tmp-2/jest.config.js
diff --git a/core/jest-extract/test/fixtures/simple/__jest-tmp-3/jest.config.js b/core/jest-extract/test/fixtures/simple/__jest-tmp-3/jest.config.js
diff --git a/examples/stories/src/tutorial/testing/jest-snapshots.mdx b/examples/stories/src/tutorial/testing/jest-snapshots.mdx
@@ -51,11 +51,20 @@ yarn add ts-jest @types/jest --dev
 "scripts": {
   ...
  "jest": {
+    // you can use a ts-jest preset
     "preset": "ts-jest",
+    // or transforms for the used files
     "transform": {
       "^.+\\.(ts|tsx)?$": "ts-jest",
       "^.+\\.(js|jsx)$": "babel-jest"
     },
+    "globals": {
+      // Temporary fix for memory leak in ts-jest, if your project is using typescript.
+      // https://github.com/kulshekhar/ts-jest/issues/1967.
+      "ts-jest": {
+        "isolatedModules": true
+      }
+    },
   },
 },
 ```

diff --git a/package.json b/package.json
@@ -85,7 +85,7 @@
     "rollup": "^2.3.2",
     "rollup-plugin-typescript2": "^0.27.0",
     "trash-cli": "^3.0.0",
-    "ts-jest": "^26.4.4",
+    "ts-jest": "^26.5.5",
     "ts-node": "^8.5.4",
     "typescript": "^4.0.5"
   },

diff --git a/plugins/addon-catalog/package.json b/plugins/addon-catalog/package.json
@@ -60,6 +60,11 @@
   ],
   "jest": {
     "preset": "ts-jest",
+    "globals": {
+      "ts-jest": {
+        "isolatedModules": true
+      }
+    },
     "roots": [
       "./src"
     ]

diff --git a/plugins/addon-images/package.json b/plugins/addon-images/package.json
@@ -61,6 +61,11 @@
   ],
   "jest": {
     "preset": "ts-jest",
+    "globals": {
+      "ts-jest": {
+        "isolatedModules": true
+      }
+    },
     "roots": [
       "./src"
     ],

diff --git a/plugins/addon-notes/package.json b/plugins/addon-notes/package.json
@@ -61,6 +61,11 @@
   ],
   "jest": {
     "preset": "ts-jest",
+    "globals": {
+      "ts-jest": {
+        "isolatedModules": true
+      }
+    },
     "roots": [
       "./src"
     ],

diff --git a/plugins/addon-stats/package.json b/plugins/addon-stats/package.json
@@ -56,6 +56,11 @@
   },
   "jest": {
     "preset": "ts-jest",
+    "globals": {
+      "ts-jest": {
+        "isolatedModules": true
+      }
+    },
     "roots": [
       "./src"
     ]

diff --git a/plugins/axe-plugin/package.json b/plugins/axe-plugin/package.json
@@ -66,6 +66,11 @@
   ],
   "jest": {
     "preset": "ts-jest",
+    "globals": {
+      "ts-jest": {
+        "isolatedModules": true
+      }
+    },
     "roots": [
       "./src"
     ]

diff --git a/plugins/cc-cli/package.json b/plugins/cc-cli/package.json
@@ -62,7 +62,7 @@
     "@types/react-test-renderer": "^16.9.3",
     "@types/testing-library__jest-dom": "^5.9.2",
     "@wojtekmaj/enzyme-adapter-react-17": "^0.3.1",
-    "babel-jest": "^26.4.4",
+    "babel-jest": "^26.6.3",
     "enzyme": "^3.11.0",
     "enzyme-to-json": "^3.5.0",
     "jest": "^26.4.2",
@@ -78,11 +78,15 @@
     "Atanas Stoyanov"
   ],
   "jest": {
-    "preset": "ts-jest",
     "transform": {
       "^.+\\.(ts|tsx)?$": "ts-jest",
       "^.+\\.(js|jsx)$": "babel-jest"
     },
+    "globals": {
+      "ts-jest": {
+        "isolatedModules": true
+      }
+    },
     "roots": [
       "./test"
     ]

diff --git a/plugins/cc-cli/test/run-document-tests.ts b/plugins/cc-cli/test/run-document-tests.ts
@@ -1,7 +1,6 @@
 import fs from 'fs';
 import path from 'path';
 import { runCLI } from 'jest';
-import { Config } from '@jest/types';
 import { createDocumentTemplate } from '../src/document-template';
 import { StoryTemplateOptions } from '../src/types';
 
@@ -44,10 +43,12 @@ export const runTests = async (
           {
             testRegex: testName,
             testPathIgnorePatterns: ['/node_modules/', '/__snapshots__/'],
+            detectOpenHandles: true,
+            runInBand: true,
             silent: true,
             verbose: false,
             watchman: false,
-          } as Config.Argv,
+          } as any,
           [__dirname],
         );
       } finally {

diff --git a/plugins/cc-cli/test/run-store-tests.ts b/plugins/cc-cli/test/run-store-tests.ts
@@ -1,7 +1,6 @@
 import fs from 'fs';
 import path from 'path';
 import { runCLI } from 'jest';
-import { Config } from '@jest/types';
 import { createStoreTemplate } from '../src/store-template';
 import { TemplateOptions } from '../src/types';
 
@@ -38,10 +37,12 @@ export const runTests = async (props: TemplateOptions): Promise<void> => {
           {
             testRegex: testName,
             testPathIgnorePatterns: ['/node_modules/', '/__snapshots__/'],
+            detectOpenHandles: true,
+            runInBand: true,
             silent: true,
             verbose: false,
             watchman: false,
-          } as Config.Argv,
+          } as any,
           [__dirname],
         );
       } finally {

diff --git a/plugins/cc-cli/test/run-story-tests.ts b/plugins/cc-cli/test/run-story-tests.ts
@@ -1,7 +1,6 @@
 import fs from 'fs';
 import path from 'path';
 import { runCLI } from 'jest';
-import { Config } from '@jest/types';
 import { createStoriesTemplate } from '../src/stories-template';
 import { StoryTemplateOptions } from '../src/types';
 
@@ -44,10 +43,13 @@ export const runTests = async (
           {
             testRegex: testName,
             testPathIgnorePatterns: ['/node_modules/', '/__snapshots__/'],
+            detectOpenHandles: true,
+            runInBand: true,
+            forceExit: true,
             silent: true,
             verbose: false,
             watchman: false,
-          } as Config.Argv,
+          } as any,
           [__dirname],
         );
       } finally {

diff --git a/plugins/figma-embed/package.json b/plugins/figma-embed/package.json
@@ -60,6 +60,11 @@
   ],
   "jest": {
     "preset": "ts-jest",
+    "globals": {
+      "ts-jest": {
+        "isolatedModules": true
+      }
+    },
     "roots": [
       "./src"
     ]

diff --git a/plugins/test-renderers/package.json b/plugins/test-renderers/package.json
@@ -55,6 +55,11 @@
   ],
   "jest": {
     "preset": "ts-jest",
+    "globals": {
+      "ts-jest": {
+        "isolatedModules": true
+      }
+    },
     "roots": [
       "./test"
     ]

diff --git a/plugins/viewport-plugin/package.json b/plugins/viewport-plugin/package.json
@@ -60,6 +60,11 @@
   ],
   "jest": {
     "preset": "ts-jest",
+    "globals": {
+      "ts-jest": {
+        "isolatedModules": true
+      }
+    },
     "roots": [
       "./src"
     ]

diff --git a/ui/app/package.json b/ui/app/package.json
@@ -66,6 +66,11 @@
   ],
   "jest": {
     "preset": "ts-jest",
+    "globals": {
+      "ts-jest": {
+        "isolatedModules": true
+      }
+    },
     "roots": [
       "./src"
     ],

diff --git a/ui/blocks/package.json b/ui/blocks/package.json
@@ -83,6 +83,11 @@
   ],
   "jest": {
     "preset": "ts-jest",
+    "globals": {
+      "ts-jest": {
+        "isolatedModules": true
+      }
+    },
     "roots": [
       "./src"
     ],

diff --git a/ui/components/package.json b/ui/components/package.json
@@ -81,9 +81,10 @@
   ],
   "jest": {
     "preset": "ts-jest",
-    "transform": {
-      "^.+\\.(ts|tsx)?$": "ts-jest",
-      "^.+\\.(js|jsx)$": "babel-jest"
+    "globals": {
+      "ts-jest": {
+        "isolatedModules": true
+      }
     },
     "moduleFileExtensions": [
       "ts",

diff --git a/ui/design-tokens/package.json b/ui/design-tokens/package.json
@@ -65,6 +65,11 @@
   ],
   "jest": {
     "preset": "ts-jest",
+    "globals": {
+      "ts-jest": {
+        "isolatedModules": true
+      }
+    },
     "roots": [
       "./src"
     ]

diff --git a/ui/editors/package.json b/ui/editors/package.json
@@ -64,6 +64,11 @@
   ],
   "jest": {
     "preset": "ts-jest",
+    "globals": {
+      "ts-jest": {
+        "isolatedModules": true
+      }
+    },
     "roots": [
       "./src"
     ]