Moved role=main logic into EuiPageComponent#47
Merged
cchaos merged 1 commit intocchaos:feat/bottom_bar_in_pagefrom Mar 31, 2021
Merged
Moved role=main logic into EuiPageComponent#47cchaos merged 1 commit intocchaos:feat/bottom_bar_in_pagefrom
cchaos merged 1 commit intocchaos:feat/bottom_bar_in_pagefrom
Conversation
10 tasks
cchaos
reviewed
Mar 31, 2021
Comment on lines
+62
to
+63
| // EuiPanel switches to a button element if onClick is provided | ||
| const role = _role ?? rest.onClick ? undefined : 'main'; |
Owner
There was a problem hiding this comment.
OOH you just meant actually adding the role="main" portion, not trying to get EuiPanel to render as a <main> element.
Owner
There was a problem hiding this comment.
Also I think I need to actually omit the onClick anyway for page content. That should never be clickable 😆 .
cchaos
approved these changes
Mar 31, 2021
Owner
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
🙇 I'm going to merge this in, then omit some of those panel props.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.