Skip to content

Redirect affordance click #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cchaos merged 1 commit into from
Mar 23, 2021
Merged

Redirect affordance click #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/components/card/checkable_card/checkable_card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* under the License.
*/

import React, { FunctionComponent, ReactNode } from 'react';
import React, { FunctionComponent, ReactNode, useRef } from 'react';
import classNames from 'classnames';

import {
Expand Down Expand Up @@ -68,6 +68,7 @@ export const EuiCheckableCard: FunctionComponent<EuiCheckableCardProps> = ({
...rest
}) => {
const { id } = rest;
const labelEl = useRef<HTMLLabelElement>(null);
const classes = classNames(
'euiCheckableCard',
{
Expand Down Expand Up @@ -96,6 +97,12 @@ export const EuiCheckableCard: FunctionComponent<EuiCheckableCardProps> = ({
'euiCheckableCard__label-isDisabled': disabled,
});

const onChangeAffordance = () => {
if (labelEl.current) {
labelEl.current.click();
}
};

return (
<EuiSplitPanel.Outer
responsive={false}
Expand All @@ -104,15 +111,14 @@ export const EuiCheckableCard: FunctionComponent<EuiCheckableCardProps> = ({
direction="row"
className={classes}>
<EuiSplitPanel.Inner
// Bubbles up the change event when clicking on the whole div for extra affordance
// @ts-ignore `onChange` doesn't match that of HTMLInput?
onClick={disabled ? undefined : () => rest.onChange()}
onClick={disabled ? undefined : onChangeAffordance}
color={checked ? 'primary' : 'subdued'}
grow={false}>
{checkableElement}
</EuiSplitPanel.Inner>
<EuiSplitPanel.Inner>
<label
ref={labelEl}
className={labelClasses}
htmlFor={id}
aria-describedby={children ? `${id}-details` : undefined}>
Expand Down