Skip to content

props/page_header#39

Merged
cchaos merged 3 commits intocchaos:props/page_headerfrom
thompsongl:props/page_header
Feb 2, 2021
Merged

props/page_header#39
cchaos merged 3 commits intocchaos:props/page_headerfrom
thompsongl:props/page_header

Conversation

@thompsongl
Copy link
Copy Markdown

  • Fix for center vs middle 😄
  • Start to some kind of "simulate with content" toggle

@cchaos
Copy link
Copy Markdown
Owner

cchaos commented Jan 29, 2021

Awesome thank you!

Fix for center vs middle 😄

🤦

@cchaos
Copy link
Copy Markdown
Owner

cchaos commented Jan 29, 2021

Is there also any way to get the rightSideContent one to work as well. That's a weird one because it's an array of nodes instead of just a straight up node.

@thompsongl
Copy link
Copy Markdown
Author

Is there also any way to get the rightSideContent one to work as well

Missed that one. Yep, I'll take a look

@cchaos
Copy link
Copy Markdown
Owner

cchaos commented Jan 29, 2021

I just pushed some updates I had been working on which caused conflicts here. But don't worry, I'll resolve those.

@thompsongl
Copy link
Copy Markdown
Author

Updated to allow for simulating rightSideContent

@cchaos cchaos merged commit b4df1a7 into cchaos:props/page_header Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants