Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added legacy support change and submit events in ie 6/7/8 #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacware
Copy link

@jacware jacware commented Oct 23, 2013

This is a simple fix for issue #7. It adds support for change and submit events in legacy ie browsers which don't support event bubbling on them. It uses a simple trick by catching the first focus event on the element and then attaching the callback to the correct event.

@kristerkari
Copy link

@ccampbell How about pulling these changes?

@thelinuxlich
Copy link

+1

gator.element.attachEvent('onfocusin', function(){
_legacyAttach(type, window.event.srcElement.form, callback)
});
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a bit odd that you're attaching three events here, you have line 37, line 42, and the later, line 47. Can you explain further what's going on here? Some comments would help.

@lazd
Copy link

lazd commented Nov 5, 2014

Dang, this project really needs tests. This particular PR would really benefit from a test that shows the problem and its fix.

@ccampbell
Copy link
Owner

Haha @lazd I totally agree. It's just a time thing

@lazd
Copy link

lazd commented Nov 5, 2014

@ccampbell sounds like a familiar struggle :) I reviewed a few PRs, filed some issues, and commented on a few things to get the conversation going again. I'll see what I can do about fixing a few things if you can get us caught up on existing issues and PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants