-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port the Java, Lua and Minecraft tests #5
Comments
FWIW, there's probably not much value in porting the Lua tests.
I'd like to imagine this is the most worthwhile porting, as it could also be used to test Fabric specific problems. Though I suspect it'll only really show its worth when updating between Minecraft versions. |
If you can successfully port these tests over, and confirm they merge, go ahead
lua tests could be helpful in finding fabric specific bugs with lua (as we have already seen via pushItems()) |
I thought about if the Lua tests should be ported, and decided that If we want tests, why not have them all. Maybe it'll catch some weird bug caused by changes we made to the fabric port. |
Have these been ported yet? I am unsure if they have completely been ported |
No, I ran into a few issues porting the Minecraft tests and have stopped working on it. |
Haha, the hacks I did to get them running on 1.16 D:. |
I think there's a fabric mod somewhere that reimplements some of mojangs stripped code so those structure tests are easier to set up. Mojang announced that code won't be stripped in 1.17 so maybe it's worth trying this again when we update. |
For future reference: Fabric recently added a game test API: FabricMC/fabric#1622 |
See #5. No gametests yet, those are more work.
Testing can help catch regressions and confirm that features work how they should.
CC:T uses three testing frameworks; a custom-built Lua testing framework, JUnit and a framework based on Mojangs in-game testing framework using kotlin.
The text was updated successfully, but these errors were encountered: