Skip to content

Conversation

per-bohlin
Copy link

@per-bohlin per-bohlin commented Jul 5, 2016

Hi,

Thanks for a useful plugin.

I've created a README file and done a naiv implementation of blocking until write to log has finished.
It simply checks the log for new content with one second interval until nothing new can be found.

I tried your suggested implementation that you had commented out, but it will not work. It causes a deadlock and the jobs freezes until a user aborts it. It is because writeWholeLogTo waits for the job to reach a COMPLETED state, which will never happen since the job is still ongoing and blocked by the plug-in's processing step. Hence my choice of implementation.

I now also added the option of using it as a build-step (in addition to post-build).

I just wanted to offer my implementation back in case you want it.

Thanks again for your contribution to the software community.

per-bohlin and others added 3 commits July 5, 2016 21:35
Fixed bug introduced by 6ba393f, that forced blocking behavior. Now the block settings is respected.
Changed minimum jenkins required version to 2.3
General cleanup
@per-bohlin per-bohlin changed the title Naiv implementation of blocking until write to log finish Use as build-step (and naiv implementation of blocking until write to log finish) Jul 24, 2017
@cboylan
Copy link
Owner

cboylan commented Jul 27, 2017

Sorry I have neglected this. We are no longer using jenkins so this hasn't been high on my radar. Would you be interested in me transfering the repo to you? or is there some way of promoting a fork? It would probably be easiest if you could just take on ownership if you are interested in the plugin I'm just not quite sure what the best way to do that on github is.

@per-bohlin
Copy link
Author

per-bohlin commented Aug 6, 2017

@cboylan , sorry for my late reply
I don't mind taking full ownership of a fork.
I guess the easiest way would be for you to update the README in your version, linking to my fork, explaining that your version is no longer maintained and that this version can be considered the "official" version from now on.
I could not find your plugin in the jenkins official plugin "market place". Have you publish your plugin in any official capacity beyond the git-hub page?

@cboylan
Copy link
Owner

cboylan commented Aug 17, 2017

I was working on pushing a README that pointed at your fork, but you don't currently have any public repositories on github. Let me know when the repo is up and I will direct people to it with a new README commit.

Thanks.

@per-bohlin
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants