-
Notifications
You must be signed in to change notification settings - Fork 39
Use as build-step (and naiv implementation of blocking until write to log finish) #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fixed bug introduced by 6ba393f, that forced blocking behavior. Now the block settings is respected. Changed minimum jenkins required version to 2.3 General cleanup
Sorry I have neglected this. We are no longer using jenkins so this hasn't been high on my radar. Would you be interested in me transfering the repo to you? or is there some way of promoting a fork? It would probably be easiest if you could just take on ownership if you are interested in the plugin I'm just not quite sure what the best way to do that on github is. |
@cboylan , sorry for my late reply |
I was working on pushing a README that pointed at your fork, but you don't currently have any public repositories on github. Let me know when the repo is up and I will direct people to it with a new README commit. Thanks. |
Add expantion of env vars in fileName.
fi=rom http -> https
Hi,
Thanks for a useful plugin.
I've created a README file and done a naiv implementation of blocking until write to log has finished.
It simply checks the log for new content with one second interval until nothing new can be found.
I tried your suggested implementation that you had commented out, but it will not work. It causes a deadlock and the jobs freezes until a user aborts it. It is because writeWholeLogTo waits for the job to reach a COMPLETED state, which will never happen since the job is still ongoing and blocked by the plug-in's processing step. Hence my choice of implementation.
I now also added the option of using it as a build-step (in addition to post-build).
I just wanted to offer my implementation back in case you want it.
Thanks again for your contribution to the software community.