Make all I/O errors fatal. Fixes potential corruption #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a transient I/O error occurred during the updates to a btree, but then I/O errors did not occur when the Database was dropped. It was possible for the file to be flushed with a clean recovery flag and broken transaction, leading to corruption. After an I/O all operations that touch the StorageBackend will now return StorageError::PreviousIo
cberner
force-pushed
the
transient_io_err
branch
from
22f18dd
to
dc6f44b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a transient I/O error occurred during the updates to a btree, but then I/O errors did not occur when the Database was dropped. It was possible for the file to be flushed with a clean recovery flag and broken transaction, leading to corruption