Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(scripts): pass OS path separator to mkdtemp #224

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

sgoudham
Copy link
Contributor

@sgoudham sgoudham commented Aug 8, 2024

The documentation states that:

The fsPromises.mkdtemp() method will append the six randomly selected characters directly to the prefix string. For instance, given a directory /tmp, if the intention is to create a temporary directory within /tmp, the prefix must end with a trailing platform-specific path separator (require('node:path').sep).

This PR updates the arguments to mkdtemp() to take in the OS-specific path separator to fix the issues on my linux system. The directories are now created as shown below:

image

@sgoudham sgoudham merged commit 3c7ce23 into main Aug 8, 2024
1 check passed
@sgoudham sgoudham deleted the fix/mktempd-args branch August 8, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant