Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text fg color configurable again #479

Closed
wants to merge 3 commits into from

Conversation

nastye
Copy link

@nastye nastye commented Feb 6, 2025

I recently updated and realized my config was incompatible and i wasn't able to reproduce my original config. I re-added the necessary options and glanced over docs to make sure there was some kind of hint at the options.

I will double check docs when i find a minute to do so :)

@kjnsn
Copy link
Collaborator

kjnsn commented Feb 6, 2025

Why doesn't set -g @catppuccin_window_number "#[fg=#{@thm_fg},bg=#{@thm_crust}] #I" work?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, what happened to the legibility?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

White background was removed (accidentally)

@@ -38,12 +38,16 @@ set -ogq @catppuccin_pane_number_position "left" # right, left

# Window options
set -ogq @catppuccin_window_status_style "basic" # basic, rounded, slanted, custom, or none
set -ogq @catppuccin_window_text_color "#{@thm_surface_0}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will you maintain backwards compatibility?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current color does what bg would do for me, so set bg to color if unset before setting to the default if unset.

@nastye
Copy link
Author

nastye commented Feb 6, 2025

Why doesn't set -g @catppuccin_window_number "#[fg=#{@thm_fg},bg=#{@thm_crust}] #I" work?

works but wasn't documented and didn't think of it. I don't mind abandoning since technically a non-issue for me then.

@kjnsn
Copy link
Collaborator

kjnsn commented Feb 6, 2025

Why doesn't set -g @catppuccin_window_number "#[fg=#{@thm_fg},bg=#{@thm_crust}] #I" work?

works but wasn't documented and didn't think of it. I don't mind abandoning since technically a non-issue for me then.

It's basic tmux styling. Will close the PR then

@kjnsn kjnsn closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants