-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update nerdfont symbols #22
Conversation
Can you review this @nekowinston @unseen-ninja @AlphaTechnolog sorry to ping just don't want a repeat of the last where it wasn't noticed really. PR should be no brainer to merge this |
Hey 👋 Winston has left the organisation and I don't believe lemon (unseen-ninja) is active at the minute. I'm happy to merge but I feel like we should include somewhere in the README what version of nerdfonts these files are shipping with? I haven't used nerdfonts in a while since my terminal fallbacks to a symbol font but I believe we can track the versions right? |
Ah sorry my bad, I didn't notice I just looked though few PRs and checked who they where merged by |
No need to apologise! Just letting you know why people might not respond to that ping. I'm unsure if AlphaTechnolog is still active. |
Newest version is Requirements
Likely older versions work but I don't feel like testing them, should I add this to the README.md? |
Another idea is to just setup a Github actions bot to just run nerdfix every so often, of course exclude any files that aren't Hint: This is over engineered |
Happy to approve once the README is updated with the requirements as per your testing. |
Done |
Lemme see if I can somehow combine those commits so it doesn't clutter git log or whatever |
Eh whatever I can't figure it out doesn't matter, I think it might automatically do it anyway when merged? I only have basic idea of how PRs work |
Don't worry about the git log 👍 |
Successor to #17 fixes all the icons in one PR with https://github.com/loichyan/nerdfix#interactive-patching