feat(home-manager): add support for ghostty

[natecox]

Fixes #427

[zakuciael]

Hi, is there any reason this PR was closed? Or if the author is no longer interested in implementing it, is it okay to make a new PR adding this module?

[natecox]

Hi, is there any reason this PR was closed? Or if the author is no longer interested in implementing it, is it okay to make a new PR adding this module?

Seemed like I was getting the runaround a bit on this without any real conversation happening to tell me why and I lost interest.

I’d be happy to pick this back up if a clear direction can be provided, I’m just not sure what to do with two reviewers asking for conflicting changes.

No hard feelings or anything, because text tends to present negatively.

[getchoo]

We're sorry about that, genuinely

There have been a lot of large refactors recently, and its made us change the approach we use in applying ports to different programs. I'll admit I'm the one who pushed a lot of these changes, and I'm more familiar with the effects they have than @isabelroses. I should have communicated these better, as well as some of the new things to look out for; that's my bad

The issue that caused this difference in review -- Import from Derivation -- is one that has been a pretty hot topic recently, and it's no doubt because of this. I plan on writing an explainer in our docs so others aren't blind sided by this again, as it's not exactly easy to catch

I'd love to see this continued, and I'll make sure to answer any questions along the way

[natecox]

All right, well I appreciate the context. Can you point out a port that is up to date that I can reference? I started with copying the kitty config (thinking it would make the port simple lol).

[natecox]

@getchoo I think I've resolved all the requests above.

[getchoo]

Otherwise this LGTM. I'll make sure to test it out soon since I know this is a popular app and port ;)

[getchoo]

Can you point out a port that is up to date that I can reference?

Honestly, I think this is already a great example of how we want these modules to be handled now 😆

But for the future, some of my favorites are

• Alacritty
• bat
• btop
• Hyprland
• k9s

With k9s and btop being the most similar to this one

The general idea is to place our port sources at the right path (or list exactly where they are) so that the program can read that at runtime. This is opposed to us reading these files at evaluation time in the modules to set options like programs.someThemeableApp.settings.hexColor = "#FFFFFF"; -- as even though Nix totally can do that, it causes some small but nasty issues

[HeitorAugustoLN]

LGTM! I have a suggestion for making the module shorter, but it doesn't really change anything besides that

[getchoo]

Tested on NixOS and all seems good!

CI did catch a new issue though: our tests against NixOS/home-manager stable fail to evaluate due to the programs.ghostty module from home-manager not being present in their 24.11 branch. It will need to be backported upstream (similar to the ghostty package) or slight hacks a neat workaround will need to be applied here to basically ignore the whole module on 24.11

Merging will be blocked by this sadly, but I'll make sure to take care of it personally since it'll probably require a good bit of effort

Thanks for your work, @natecox. I hope to ping you again soon with a merge :)

[natecox]

oof, I didn't realize that it wasn't on the 24.11 branch; living on unstable bites again I guess.

[getchoo]

nix-community/home-manager#6285

[getchoo]

Sorry for the delay, have been with family for the last few days ;)

CI is happy now, so I think this is ready for a merge. Thanks again for your work, @natecox and I hope to see you around!