Fix clang-tidy bugprone-chained-comparison warnings
#2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI has exploded so perhaps this is not the right fix |
This triggers when running clang-tidy's bugprone-* family of checks in code which uses Catch2 even if Catch2 headers are marked as SYSTEM headers due to how code expanded from macros is treated as first party even if the macro comes from a 3rd party library. The fix is luckily pretty straightforward. This check is added in clang-tidy-18 due for release later this year.
ChrisThrasher
force-pushed
the
clang-tidy-bugprone-chained-comparison
branch
from
0063b72
to
89c9778
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2801 +/- ##
==========================================
+ Coverage 91.37% 91.39% +0.02%
==========================================
Files 197 197
Lines 8285 8285
==========================================
+ Hits 7570 7572 +2
+ Misses 715 713 -2 |
|
Looks like we can't change the C++ to fix this and instead have to add a new suppression to deal with this. I don't love having to do this but it's worth it for providing a better user experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This triggers when running clang-tidy's bugprone-* family of checks in code which uses Catch2 even if Catch2 headers are marked as SYSTEM headers due to how code expanded from macros is treated as first party even if the macro comes from a 3rd party library. The fix is luckily pretty straightforward.
This check is added in clang-tidy-18 due for release later this year.
llvm/llvm-project#76365