Suppress clang-tidy warning about vararg usage in assertion macros #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CATCH_INTERNAL_IGNORE_BUT_WARN() introduced with b7b346c triggers clang-tidy warning 'cppcoreguidelines-pro-type-vararg' for every usage of assertion macros like CHECK() and REQUIRE(). Silence it via NOLINT in the '#if defined(__clang__)' block only, as clang-tidy honors those.
Codecov Report
@@ Coverage Diff @@
## master #1901 +/- ##
=======================================
Coverage 86.49% 86.49%
=======================================
Files 131 131
Lines 3900 3900
=======================================
Hits 3373 3373
Misses 527 527 |
|
Okay, but I have no idea where function-level varargs are used. 🤔 |
|
I checked again. It actually complains about a call to a "c-style vararg function" and points to the invocation of |
|
Fair. |
horenmar
added a commit
that referenced
this pull request
Apr 21, 2020
--- Improvements --- * Running tests in random order (`--order rand`) has been reworked significantly (#1908) * Given same seed, all platforms now produce the same order * Given same seed, the relative order of tests does not change if you select only a subset of them * Vector matchers support custom allocators (#1909) * `|` and `&` (bitwise or and bitwise and) are now supported in `CHECK` and `REQUIRE` * The resulting type must be convertible to `bool` --- Fixes --- * Fixed computation of benchmarking column widths in ConsoleReporter (#1885, #1886) * Suppressed clang-tidy's `cppcoreguidelines-pro-type-vararg` in assertions (#1901) * It was a false positive trigered by the new warning support workaround * Fixed bug in test specification parser handling of OR'd patterns using escaping (#1905) --- Miscellaneous --- * Worked around IBM XL's codegen bug (#1907) * It would emit code for _destructors_ of temporaries in an unevaluated context * Improved detection of stdlib's support for `std::uncaught_exceptions` (#1911)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CATCH_INTERNAL_IGNORE_BUT_WARN()introduced with b7b346c (*) triggers clang-tidy warning cppcoreguidelines-pro-type-vararg for every usage of assertion macros likeCHECK()andREQUIRE(). Silence it viaNOLINTin the#if defined(__clang__)block only, as clang-tidy honors those.(*) Thanks for that one BTW, uncovered a few warnings in our test code.
GitHub Issues
n/a (decided to try to file PR instead of creating a ticket)