Catch: resolve inconsistency in CATCH_REQUIRE_THROWS #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The REQUIRE_THROWS and CATCH_REQUIRE_THROWS macros have a subtle inconsistency in their implementation which can cause a warning if [-Wunused-value] is used. This commit changes CATCH_REQUIRE_THROWS so it has the same implementation as REQUIRE_THROWS It looks like REQUIRE_THROWS was change in commit fae0fa4 but not CATCH_REQUIRE_THROWS. Similar changes for CATCH_CHECK_THROWS
suspend0
force-pushed
the
catch-require-throws-inconsistency
branch
from
f522ca5 to
8c35a66
Compare
Codecov Report
@@ Coverage Diff @@
## master #1536 +/- ##
======================================
Coverage 80.6% 80.6%
======================================
Files 121 121
Lines 3386 3386
======================================
Hits 2729 2729
Misses 657 657 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The REQUIRE_THROWS and CATCH_REQUIRE_THROWS macros have
a subtle inconsistency in their implementation which can
cause a warning if [-Wunused-value] is used.
This commit changes CATCH_REQUIRE_THROWS so it has the
same implementation as REQUIRE_THROWS
It looks like REQUIRE_THROWS was changed in commit
fae0fa4 but not CHECK_REQUIRE_THROWS.
Tested on: