Fix convert from char on ARM build #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some platforms set the signedness of char to unsigned (eg. ARM). Convert from char should not assume the signedness of char. Fix build issue with -Werror,-Wtautological-unsigned-zero-compare flags. Signed-off-by: Miguel Gaio <[email protected]>
Closed
Codecov Report
@@ Coverage Diff @@
## master #1399 +/- ##
==========================================
+ Coverage 80.08% 80.14% +0.06%
==========================================
Files 119 119
Lines 3389 3389
==========================================
+ Hits 2714 2716 +2
+ Misses 675 673 -2 |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some platforms set the signedness of char to unsigned (eg. ARM).
Convert from char should not assume the signedness of char.
Fix build issue with -Werror,-Wtautological-unsigned-zero-compare flags.
Signed-off-by: Miguel Gaio [email protected]
Description
This fix build issue on ARM target with -Werror,-Wtautological-unsigned-zero-compare flags.
Following compiler logs is observed
catch2/include/internal/catch_tostring.cpp:217:21: error: comparison of 0 <= unsigned expression is always true [-Werror,-Wtautological-unsigned-zero-compare]
} else if ('\0' <= value && value < ' ') {
GitHub Issues
N/A