Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::aligned_storage is deprecated in C++23 #2419

Closed
marcmutz opened this issue May 7, 2022 · 2 comments
Closed

std::aligned_storage is deprecated in C++23 #2419

marcmutz opened this issue May 7, 2022 · 2 comments

Comments

@marcmutz
Copy link

marcmutz commented May 7, 2022

ObjectStorage is using std::aligned_storage, but C++23 deprecates it, causing warnings in projects that already use -std=c++2b.
@marcmutz marcmutz mentioned this issue May 7, 2022
Merged
horenmar pushed a commit that referenced this issue May 9, 2022
@marcmutz @horenmar
ObjectStorage: port away from std::aligned_storage
ca45581 
It's deprecated in C++23. Just use alignas on a char array, wrapped in
a struct to avoid decaying to char*, which is the canonical
implementation of aligned_storage:
https://en.cppreference.com/w/cpp/types/aligned_storage#Possible_implementation

Fixes #2419

Catch3 is not affected.
@horenmar horenmar closed this as completed May 9, 2022
@marcmutz
Copy link
Author

@horenmar Do you still plan to make a 2.13.10 release, or should Catch2 users now simply use HEAD?

@horenmar
Copy link
Member

I completely forgot there were meaningful changes there.

https://github.com/catchorg/Catch2/releases/tag/v2.13.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@horenmar @marcmutz