[Tasks] Schema simplification (EQEmu#2449)

* Combine task_activity item and npc fields This will make tooling easier. While denormalizing goallists may not be ideal, it decouples tasks from rewards which share the table and removes a redundant column in favor of a using the delimited string which better matches live packet data. * [Tasks] Deprecate goallists table, migrate reward goal lists, simplify logic * Update 2022_09_25_task_concat_matchlists.sql * Update 2022_09_25_task_concat_matchlists.sql * Tweaks * Fix reward column name in conversion script * Task reward stacking * Update task_client_state.cpp * Implement stack counts * Fix reward item instance memory leak * Validate reward item instance * Fix item reward message * Fix findtask Co-authored-by: Akkadius <[email protected]>
catapultam-habeo · Mar 27, 2023 · 2a847e0 · 2a847e0
1 parent ccb39f0
commit 2a847e0
Show file tree

Hide file tree

Showing 23 changed files with 498 additions and 1,113 deletions.
diff --git a/common/CMakeLists.txt b/common/CMakeLists.txt
@@ -207,7 +207,6 @@ SET(repositories
     repositories/base/base_friends_repository.h
     repositories/base/base_global_loot_repository.h
     repositories/base/base_gm_ips_repository.h
-    repositories/base/base_goallists_repository.h
     repositories/base/base_graveyard_repository.h
     repositories/base/base_ground_spawns_repository.h
     repositories/base/base_group_id_repository.h
@@ -384,7 +383,6 @@ SET(repositories
     repositories/friends_repository.h
     repositories/global_loot_repository.h
     repositories/gm_ips_repository.h
-    repositories/goallists_repository.h
     repositories/graveyard_repository.h
     repositories/ground_spawns_repository.h
     repositories/group_id_repository.h

diff --git a/common/database_schema.h b/common/database_schema.h
@@ -197,7 +197,6 @@ namespace DatabaseSchema {
 			"fishing",
 			"forage",
 			"global_loot",
-			"goallists",
 			"graveyard",
 			"grid",
 			"grid_entries",

diff --git a/common/repositories/base/base_goallists_repository.h b/common/repositories/base/base_goallists_repository.h