-
Notifications
You must be signed in to change notification settings - Fork 565
ES6 feature introduction: classes #2176
Comments
Awesome! Thanks so much for doing this Ethan! I'd love to hear more as progress is made. |
Hey Ethan, any update on when you might be able to try this out? |
It turns out that I'm happy to push on this but we should find another place to do it -- I think you had another small class in mind? |
(We talked about this offline, and I suggested either |
I'm working on a big patch to convert the |
Revisiting this, folks are already using classes; I think we should turn them on in the style guide. |
Folks are already using ES6 classes in tracing and everything seems to work fine. Let's approve them in the style guide. BUG=catapult:#2176 Review-Url: https://codereview.chromium.org/2282563002
Should we convert all classes to use proper classes? |
Converting at least the Event hierarchy would fix the prototype.constructor link, which would vastly simplify EventRegistry as discussed in https://codereview.chromium.org/2242733002/ grep says there are 499 instances of '.prototype = '. So that's a lot of typing. But there are only a dozen or two classes in the Event hierarchy, iirc. |
Since @zeptonaut has initiated a procedure for opening up the tracing codebase to new ES6 features, we want to try classes next.
I'm doing some refactoring on
Numeric
right now, and it occurred to me that this would probably be a good place to start, since numerics are used by a fair amount of unit tested code, but not in so many places that any refactoring that has to be done would be insurmountable.The text was updated successfully, but these errors were encountered: