Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

ES6 feature introduction: arrow functions #2165

Closed
zeptonaut opened this issue Mar 21, 2016 · 4 comments
Closed

ES6 feature introduction: arrow functions #2165

zeptonaut opened this issue Mar 21, 2016 · 4 comments

Comments

@zeptonaut
Copy link
Contributor

Arrow functions are the first feature from ES6 that we're trying to introduce into trace viewer. Based on this thread, I don't think that anyone has any real objections to using arrow functions as long as they work with all of our dependents.

Because they're the first ES6 feature that we're introducing, we need to be extra careful to make sure that we don't break anything downstream in an unanticipated way. I've submitted https://codereview.chromium.org/1358233002/ as a means of introducing arrow functions in a very core part of the code that should break any dependents in an easily-revertable way.

If, in a couple of weeks, nothing has blown up, we should be able to start using arrow functions throughout the codebase.

cc: @natduca @eakuefner @petrcermak

@zeptonaut zeptonaut self-assigned this Mar 21, 2016
@zeptonaut zeptonaut added this to the M51 milestone Mar 21, 2016
@natduca
Copy link
Contributor

natduca commented Mar 21, 2016

\o/

@petrcermak
Copy link
Contributor

I suppose arrow functions can now (after more than 2 weeks of no downstream breakage reports) be marked as "stable". Perhaps we should have a Catapult guide on which ES6 features are considered "safe".

@eakuefner
Copy link
Contributor

We do: https://github.com/catapult-project/catapult/blob/master/docs/style-guide.md

Charlie, do you want to update the table and close this bug?

@zeptonaut
Copy link
Contributor Author

I'd love to!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants