Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL mnist #1368

Merged
merged 4 commits into from
Dec 6, 2021
Merged

SSL mnist #1368

merged 4 commits into from
Dec 6, 2021

Conversation

Scitator
Copy link
Member

@Scitator Scitator commented Dec 5, 2021

Pull Request FAQ

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Checklist

  • Have you updated tests for the new functionality?
  • Have you added your new classes/functions to the docs?
  • Have you updated the CHANGELOG?
  • Have you run colab minimal CI/CD with latest and minimal requirements?
  • Have you checked XLA integration with single and multiple processes?

@Scitator Scitator requested review from bagxi and ditwoo as code owners December 5, 2021 14:06
@pep8speaks
Copy link

pep8speaks commented Dec 5, 2021

Hello @Scitator! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 189:5: E722 do not use bare 'except'

Comment last updated at 2021-12-06 07:27:06 UTC

@Scitator Scitator merged commit ff44f11 into master Dec 6, 2021
@mergify mergify bot deleted the ssl-mnist branch December 6, 2021 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants