Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #1303

Merged
merged 9 commits into from
Sep 27, 2021
Merged

Cleanup #1303

merged 9 commits into from
Sep 27, 2021

Conversation

Scitator
Copy link
Member

Before submitting (checklist)

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest . ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?
  • Did you run colab minimal CI/CD with latest and minimal requirements?
  • Did you check XLA integration with single and multiple processes?

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

FAQ

Please review the FAQ before submitting an issue:

github-actions[bot]
github-actions bot reviewed Sep 23, 2021
View reviewed changes
catalyst/callbacks/sklearn_model.py Outdated
@@ -48,7 +48,7 @@ class SklearnModelCallback(Callback):
download=True,
transform=transforms
)
sampler = data.BalanceBatchSampler(labels=train_dataset.get_labels(), p=5, k=10)
sampler = data.BatchBalanceClassSampler(labels=train_dataset.get_labels(), num_classes=5, num_samples=10)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
E501 line too long (117 > 99 characters)

catalyst/callbacks/sklearn_model.py Outdated
@@ -48,7 +48,7 @@ class SklearnModelCallback(Callback):
download=True,
transform=transforms
)
sampler = data.BalanceBatchSampler(labels=train_dataset.get_labels(), p=5, k=10)
sampler = data.BatchBalanceClassSampler(labels=train_dataset.get_labels(), num_classes=5, num_samples=10)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
W505 doc line too long (117 > 99 characters)

catalyst/callbacks/sklearn_model.py Outdated
@@ -137,7 +137,7 @@ def handle_batch(self, batch) -> None:
download=True,
transform=transforms
)
sampler = data.BalanceBatchSampler(labels=train_dataset.get_labels(), p=5, k=10)
sampler = data.BatchBalanceClassSampler(labels=train_dataset.get_labels(), num_classes=5, num_samples=10)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
E501 line too long (117 > 99 characters)

catalyst/callbacks/sklearn_model.py Outdated
@@ -137,7 +137,7 @@ def handle_batch(self, batch) -> None:
download=True,
transform=transforms
)
sampler = data.BalanceBatchSampler(labels=train_dataset.get_labels(), p=5, k=10)
sampler = data.BatchBalanceClassSampler(labels=train_dataset.get_labels(), num_classes=5, num_samples=10)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
W505 doc line too long (117 > 99 characters)

catalyst/callbacks/metrics/cmc_score.py Outdated
@@ -52,7 +52,7 @@ class CMCScoreCallback(LoaderMetricCallback):
train_dataset = datasets.MnistMLDataset(
root=os.getcwd(), download=True, transform=transforms
)
sampler = data.BalanceBatchSampler(labels=train_dataset.get_labels(), p=5, k=10)
sampler = data.BatchBalanceClassSampler(labels=train_dataset.get_labels(), num_classes=5, num_samples=10)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
E501 line too long (113 > 99 characters)

catalyst/callbacks/metrics/cmc_score.py Outdated
@@ -52,7 +52,7 @@ class CMCScoreCallback(LoaderMetricCallback):
train_dataset = datasets.MnistMLDataset(
root=os.getcwd(), download=True, transform=transforms
)
sampler = data.BalanceBatchSampler(labels=train_dataset.get_labels(), p=5, k=10)
sampler = data.BatchBalanceClassSampler(labels=train_dataset.get_labels(), num_classes=5, num_samples=10)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
W505 doc line too long (113 > 99 characters)

catalyst/metrics/_cmc_score.py Outdated
@@ -74,7 +74,7 @@ class CMCMetric(AccumulativeMetric):
train_dataset = datasets.MnistMLDataset(
root=os.getcwd(), download=True, transform=transforms
)
sampler = data.BalanceBatchSampler(labels=train_dataset.get_labels(), p=5, k=10)
sampler = data.BatchBalanceClassSampler(labels=train_dataset.get_labels(), num_classes=5, num_samples=10)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
E501 line too long (113 > 99 characters)

catalyst/metrics/_cmc_score.py Outdated
@@ -74,7 +74,7 @@ class CMCMetric(AccumulativeMetric):
train_dataset = datasets.MnistMLDataset(
root=os.getcwd(), download=True, transform=transforms
)
sampler = data.BalanceBatchSampler(labels=train_dataset.get_labels(), p=5, k=10)
sampler = data.BatchBalanceClassSampler(labels=train_dataset.get_labels(), num_classes=5, num_samples=10)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
W505 doc line too long (113 > 99 characters)

tests/catalyst/callbacks/test_metric.py Outdated
@@ -217,7 +217,7 @@ def test_metric_learning_pipeline():
"""
with TemporaryDirectory() as tmp_dir:
dataset_train = datasets.MnistMLDataset(root=tmp_dir, download=True)
sampler = data.BalanceBatchSampler(labels=dataset_train.get_labels(), p=5, k=10)
sampler = data.BatchBalanceClassSampler(labels=dataset_train.get_labels(), num_classes=5, num_samples=10)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
E501 line too long (113 > 99 characters)

tests/catalyst/callbacks/test_metric.py Outdated
@@ -273,7 +273,7 @@ def test_reid_pipeline():
transforms = Compose([ToTensor(), Normalize((0.1307,), (0.3081,))])

train_dataset = MnistMLDataset(root=os.getcwd(), download=True, transform=transforms)
sampler = data.BalanceBatchSampler(labels=train_dataset.get_labels(), p=5, k=10)
sampler = data.BatchBalanceClassSampler(labels=train_dataset.get_labels(), num_classes=5, num_samples=10)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pep8] reported by reviewdog 🐶
E501 line too long (113 > 99 characters)

@pep8speaks
Copy link

pep8speaks commented Sep 23, 2021 •
edited
Loading

Hello @Scitator! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-09-27 04:53:40 UTC

github-actions[bot]
github-actions bot reviewed Sep 23, 2021
View reviewed changes
catalyst/contrib/utils/report.py Show resolved Hide resolved
catalyst/contrib/utils/report.py Outdated Show resolved Hide resolved
catalyst/contrib/utils/report.py Outdated Show resolved Hide resolved
catalyst/contrib/utils/report.py Outdated Show resolved Hide resolved
catalyst/contrib/utils/report.py Outdated Show resolved Hide resolved
@mergify
Copy link

mergify bot commented Sep 24, 2021

This pull request is now in conflicts. @Scitator, could you fix it? 🙏

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@Scitator Scitator merged commit 185b892 into master Sep 27, 2021
@mergify mergify bot deleted the fix/sampler-fix branch September 27, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@bagxi bagxi Awaiting requested review from bagxi bagxi is a code owner

@ditwoo ditwoo Awaiting requested review from ditwoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Scitator @pep8speaks