Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): wrist and ankle sheaths can fit pocket knives #5977

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Jan 25, 2025

Purpose of change

Pocket knives have the SHEATH_KNIFE flag, but no actual sheath can fit them because back when I sanity-checked the min volume of small sheathes I only had scalpels in mind, and pocket knives are 5 ml smaller.

Describe the solution

  1. Lowered min_volume of wrist sheath from 15 ml to 10 ml.
  2. Lowered min_volume of ankle sheath from 15 ml to 10 ml.

Describe alternatives you've considered

  1. Making pocket knives bigger.
  2. Lowering min volume for these items all the way down to 1 ml just to make 100% sure this can never happen again.

Testing

Checked that there no longer any vanilla SHEATH_KNIFE items below the new volume limit.

Additional context

Another one spotted by Ekarus. :3

Checklist

Mandatory

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 25, 2025
@chaosvolt chaosvolt merged commit 108b042 into cataclysmbnteam:main Jan 26, 2025
13 checks passed
@chaosvolt chaosvolt deleted the knives-out-for-harambe branch January 26, 2025 00:36
@scarf005
Copy link
Member

scarf005 commented Jan 26, 2025

why do we need min_volume anyways?

@chaosvolt
Copy link
Member Author

why do we need min_volume anyways?

Do not tempt me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants