fix: cables duplication

[Goredell]

Why should this PR be merged?

• fixes Duplicating Jumper Cables #5122

What does this PR do?

Fixes cables not being removed after linking vehicles, by revisiting some of the logic changes from #4968, without disturbing the work done

Steps to test and verify this PR

"Using" things that use charges and should or should not "disappear" after.

Checklist

Mandatory

• I wrote the PR title in conventional commit format.
• I ran the code formatter.
• I linked any relevant issues using github keyword syntax like closes #1234 in Summary of the PR so it can be closed automatically.
• I've committed my changes to new branch that isn't main so it won't cause conflict when updating main branch later.

[Goredell]

IMO this is still done in an incredibly ugly way, items with a special way of handling charges and their dis//re-appearance - such as cables, should be handled somehow more explicit

[scarf005]

I've fixed the link but please read the checklist before checking next time.

[Goredell]

I've fixed the link but please read the checklist before checking next time.

Thanks, boss, sorry, boss

[scarf005]

I've fixed the link but please read the checklist before checking next time.

Thanks, boss, sorry, boss

no worries, should've added fixes in PR template anyways

[chaosvolt]

1. Compiled and load-tested.
2. Spawned in a pair of jumper cables, and used them plus a shopping cart to bootleg a connection across two tiles, no duplicate jumper cables left in inventory.
3. Spawned in a battery in the area now linked to the evac shelter, confirmed that examining the battery tells you about the grid it's bootleg-linked to, and confirmed after enough waiting that it will charge eventually.
4. Spawned in a compound bow, cycling through different modes works as expected.
5. Spawned in and lit a flare, it turned into a lit flare then a dead flare on running out, as expected.
6. Spawned in a flashlight, turning on and off works as expected, and behaves as intended on running out of charges.

Bug: Spawned in Rising Sun, activated it, and let it run out of charges. It vanishes, this PR reintroduces #5868. Note that while fire weapons are currently obsoleted in mainline, they are still in use in in-repo mods and bringing them back into mainline is still on the table for things we're thinking about doing someday, plus the function finds use for items in other mods out there.

[autofix-ci]

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix

1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
2. Continue working.

I do not want the automated commit

1. Format your code locally, then commit it.
2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

[Goredell]

So, since previous change introduced a bug with vanishing items, I made a decision to handle those in explicit way, to remove a possibility of unexpected item vanishing.
Also found a new bug, throwable fire extinguishers don't actually pop, when thrown on fire. Don't want to fix it here, gonan fill out a proper issue.

[chaosvolt]

Oh fuck me. So I've got good news and bad news.

Good news is, it's not your PR that did this. I just tested in 2025-01-22 and it still happens. Bad news is the bug either has returned from beyond the grave after #5870 was merged or that PR was merged without testing (can't tell, but PR OP indicates I was asked to test as Kheir was busy and I didn't get to it in time before it got merged)

[chaosvolt]

Apologies for the false positive on the bug, since everything else works fine and I confirmed the fire weapon bug is present in one of the most recent releases, this is good to go.

If you want to go back to the other implementation instead that'd be fine, though having an item flag for tools that vanish when used up is actually something that's been on my "to look into someday" list since it'll be useful for other stuff in the future, so I kinda really like this implementation too.

EDIT: Went ahead with the merge since honestly the derailment due to finding an unrelated bug has kept you waiting long enough already, I screm

[scarf005]

Also found a new bug, throwable fire extinguishers don't actually pop, when thrown on fire. Don't want to fix it here, gonan fill out a proper issue.

that would be #3723