Skip to content

docs: Properly link to custom clang-tidy plugin instructions #5886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RobbieNeko
Copy link
Collaborator

Checklist

Required

Purpose of change

Docs hasn't been deploying since approximately 3 months ago, meaning any documentation changes in the meantime just never showed up on the website.

Describe the solution

Fixes the invalid link by properly linking to it instead of trying to do a relative path.

Describe alternatives you've considered

  • Let Scarf know and have him fix it
  • Weh

Testing

Unable

Additional context

I find it really funny that Scarf literally made the docs, but also made the PR that stopped them from deploying for 3 months

Links have to be valid when it's on its own website too
@github-actions github-actions bot added the docs PRs releated to docs page label Jan 6, 2025
Copy link
Contributor

autofix-ci bot commented Jan 6, 2025

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@scarf005 scarf005 merged commit a762398 into cataclysmbnteam:main Jan 6, 2025
3 checks passed
@scarf005
Copy link
Member

scarf005 commented Jan 6, 2025

weird that broken link bork the whole pipeline

@RobbieNeko RobbieNeko deleted the scarf-you-literally-MADE-the-docs branch March 21, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PRs releated to docs page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants