fix: don't spawn grenade launchers installed on magazines #4192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
So recently I spotted a weird lil error: when a gun spawn (like zombie soldier drops) generates the grenadier variant, it also spawns M203s attached to the spare magazines that spawn, leading to this oddity when you try to unload them:
Along the way I spotted another smol mistake that I figured is minor enough to bundle in this.
Describe the solution
military_standard_grenadier
to define grenadier-specific versions of the sub-itemgroups inmilitary_standard_assault_rifles
instead of using the itemgroup wholesale, so it won't also apply the gunmod to the spare mags derp.military_accessories_grenadier
added to them, then the relevant spare mags.clothing_tactical_leg
having two calls to spawn hand grenade pouches instead of one call to that and a call to grenade ammo pouches.Describe alternatives you've considered
Screaming.
Testing
Additional context
Checklist