Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): closed glass windows block scent #4114

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

RoyalFox2140
Copy link
Collaborator

Purpose of change

After discussing it, it's reasonable to have closed glass windows block scent from traveling outside. Fixes #4112

Enables players to hide in buildings by having all closed glass windows block scent. IRL windows aren't 100% airtight but they should also feasibly be airtight enough that the smell will barely travel through it. In addition, I expect this to not dramatically alter balance because it only allows you to hide, not to fight or run away. If you shouldn't be in an area you'll still die.

Describe the solution

The flag "NO_SCENT" was added to all relevant entries, replacing "REDUCE_SCENT" where applicable

Describe alternatives you've considered

suffering

Testing

image

Additional context

Doors don't block scent at all either. That's a concern for another day. Also this file hilariously uses almost no copy-froms and inheritance.

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jan 15, 2024
Copy link
Contributor

autofix-ci bot commented Jan 15, 2024

The Autofix app has found code style violation and automatically formatted this Pull Request.

I locally edit my commits (e.g: git, github desktop)

Please choose following options:

I'd like to accept the automated commit
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

This PR is complete and I don't want to edit it anymore

It's safe to ignore this message.

I edit this PR through web UI

You can ignore this message and continue working.

I have no idea what this message is talking about

You can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005.

@chaosvolt chaosvolt merged commit 0d69820 into cataclysmbnteam:main Jan 16, 2024
9 checks passed
@RoyalFox2140 RoyalFox2140 deleted the windows-are-glass branch January 16, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scent travels through glass windows
3 participants