feat(balance): closed glass windows block scent #4114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
After discussing it, it's reasonable to have closed glass windows block scent from traveling outside. Fixes #4112
Enables players to hide in buildings by having all closed glass windows block scent. IRL windows aren't 100% airtight but they should also feasibly be airtight enough that the smell will barely travel through it. In addition, I expect this to not dramatically alter balance because it only allows you to hide, not to fight or run away. If you shouldn't be in an area you'll still die.
Describe the solution
The flag "NO_SCENT" was added to all relevant entries, replacing "REDUCE_SCENT" where applicable
Describe alternatives you've considered
suffering
Testing
Additional context
Doors don't block scent at all either. That's a concern for another day. Also this file hilariously uses almost no copy-froms and inheritance.