Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): Phase out some redundant bionics, add bionic infolink #4106

Merged
merged 8 commits into from
Jan 14, 2024

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Jan 13, 2024

Purpose of change

This does a bit of work towards phasing out a couple of completely redundant and pointless bionics, improving underwhelming ones, and/or packaging some functions that could reasonably be combined. Goal is reducing a few cases where a bionic is in some way not worth the hassle of installing.

Describe the solution

C++ changes:

  1. In character.cpp, bumped the brightness of cranial flashlight from 60 up to 300, to match that of a regular flashlight. It's a bionic installation that's overall more effort to set up than just wearing a headlamp, so making it comparable seems reasonable.
  2. Also, on being talked into keeping it, bumped brightness of LED tats from 5 to 40, on the basis of making it about 1/8th that of cranial flashlight since it drains 1/8th the power.
  3. In general, changed all uses of bio_watch and bio_infolink in avatar.cpp, bionics.cpp, character.cpp, panels.cpp, player_hardcoded_effect.cpp, and sounds.cpp to refer to a new bionic as mentioned below that replaces both internal chronometer and weather reader...
  4. And in addition, added references to infolink in the relevant functions in faction.cpp and npcmove.cpp so that they count as a two-way radio for the purpose of communications.

JSON changes:

  1. Obsoleted directional EMP CBM, as the EMP arm gun does everything it does at the same power cost, but with 10 times the range. Only real benefit is lower slot usage but that can be adjusted if ever desired.
  2. Bumped power draw of cranial flashlight from 3 joules to 8, making it 80% the wattage of a basic flashlight.
  3. Obsoleted internal chronometer and weather reader bionics, with descriptions indicating the bionics are now useless (for old saves), in favor of...
  4. Bionic Infolink, in the vein of things like JC Denton constantly being harassed by every NPC in the game. Described as a communications package, as such it provides both the watch and weather reader functions but additionally doubles as a two-way radio. Picked slot usage and install difficulty of weather reader.
  5. Removed obsoleted bionics from itemgroups and professions, replacing with their counterparts where needed.
  6. As a bonus for the extra Deus Ex experience, added bionic infolink to bionic agent profession.
  7. Likewise removed where relevant from mods folders.
  8. Removed watch and phone from professions that get an infolink. :3

Describe alternatives you've considered

I was originally gonna obsolete the LED tattoo and water extractor CBMs, but got talked into rebalancing the LED tats a bit to be more actually worth using, and talked into keeping extractor for now because it'll make it less hassle to convert it to be less fucking weird like it currently is.

Testing

  1. Checked affected JSON for syntax and lint errors.
  2. Compiled and load-tested.
  3. Tested that light radius of cranial flashlight when underground matches that of a normal flashlight.
  4. Installed a bionic infolink, confirmed I get time and temp info, activation gives me weather report.
  5. Recruited starter NPC and gave them a two-way radio, confirmed on teleporting away it let me talk with them.

Additional context

I've already got another idea for a bionic to add (an electroreception CBM that will combine the utility of the Electoreceptor mutation, a bionic scanner, and a voltmeter) but figuring out how to code that one seems complex enough I'd rather save it for later.

Checklist

@github-actions github-actions bot added src changes related to source code. JSON related to game datas in JSON format. mods PR changes related to mods. labels Jan 13, 2024
@chaosvolt chaosvolt changed the title Bionic merges and obsoletion feat(balance): Phase out some redundant bionics, add bionic infolink Jan 13, 2024
@EkarusRyndren
Copy link
Contributor

The rest is good but can we please keep the tattoo? I like having it for RP reasons.

@chaosvolt
Copy link
Member Author

Pain. Between that and possible plans to rework the water extractor into something that purifies water en mass, I might I guess undo the obsoletion of water extractor and LED tattoo I guess weh XD

@chaosvolt chaosvolt marked this pull request as draft January 13, 2024 21:56
@RoyalFox2140
Copy link
Collaborator

Pain. Between that and possible plans to rework the water extractor into something that purifies water en mass, I might I guess undo the obsoletion of water extractor and LED tattoo I guess weh XD

No reason to hold up the PR because I have longterm plans to do something with the water extractor. If its just in obsolete.json it can be resurrected as fast as it was killed. LED tattoo is its own story and I already commented that we work with ascii and 32x32 so you can't meaningfully represent such sprites on the character, a tattoo system in general is menu text if it doesn't glow enough to be useful.

@chaosvolt
Copy link
Member Author

Auuuugh make your minds weh. I'm gonna just make the LED tattoo bright enough to ensure it actually lets you craft and unobsolete it, plus not like it really hurts to have it in weh XD

@github-actions github-actions bot removed the mods PR changes related to mods. label Jan 13, 2024
@chaosvolt chaosvolt marked this pull request as ready for review January 13, 2024 22:17
@scarf005 scarf005 self-requested a review January 14, 2024 01:27
@scarf005 scarf005 self-assigned this Jan 14, 2024
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging multiple small CBMs into one sounds like a good QoL improvement.

@scarf005 scarf005 merged commit 36fe4af into cataclysmbnteam:main Jan 14, 2024
12 checks passed
@chaosvolt chaosvolt deleted the bionic-merges-and-obsoletion branch January 14, 2024 01:33
@ZChris13
Copy link

ZChris13 commented Aug 8, 2024

Man, I come back and you've obsoleted one of the best bionics. Directional EMP was good because it was a melee attack and couldn't miss if you ended up in melee with a robot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants