-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(mods/craftgp): add Luty's book and mainline recipes for the Luty SMGs #4050
Conversation
The Autofix app has found code style violation and automatically formatted this Pull Request. I locally edit my commits (e.g: git, github desktop)Please choose following options: I'd like to accept the automated commit
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. This PR is complete and I don't want to edit it anymoreIt's safe to ignore this message. I edit this PR through web UIYou can ignore this message and continue working. I have no idea what this message is talking aboutYou can ignore this message and continue working. If you find any problem, please ask for help and ping @scarf005. |
is this a port of an existing mod? if so, could we get the name and email of original author? this is needed to properly attribute original author. |
This is mainlining the 3 SMG recipes found in the in-repo Craftable Gun Pack mod, yes. Noctifer-de-Mortem e256d2c being the original addition, and 21d7072 being the follow-up that set Noct as maintainer of that mod and also changed the recipes to be what they are today |
Co-authored-by: Zaweri <[email protected]> Co-authored-by: Noctifer-de-Mortem <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purpose of change
There aren't many craftable firearms in the vanilla game at the moment, and the entire point of the Luty submachine guns irl was to be able to be made from materials and using tools that you can easily obtain at a hardware store. Thus, this felt like a perfect match for adding some of these recipes in, especially considering how we already have the Luty submachine guns in the game in the first place.
Describe the solution
Describe alternatives you've considered
Leave the recipes out of mainline and just leave them in the CGP
I just don't see the point in having the Luty submachine guns in mainline if we don't have a way to craft them in mainline
Remove the autolearn from the recipes and just have it be booklearn
We all know how infuriating it can be when you're locked out of a recipe by a rare book. Besides, a survivor would surely at least come up with a similar design after a certain amount of study on their own.
Just keep the guns as autolearn without adding the book
Valid, just felt like tossing the booklearn in there as a nice bonus to people who find it.
Testing
Made sure it does not yell at me upon loading into a world or spawning the book or looking at the recipes. Did not confirm that the book actually spawns in the correct itemgroups, but that's because I could easily see it being infuriating to check for that. (Also, I feel any errors that would actually cause such an issue large enough that the game either would yell at me, or that it would be affecting many more items)
Additional context
Credit for the original SMG recipes found in the Craftable Gun Pack that are being mainlined goes to Noctifer-de-Mortem
Expedient Homemade Firearms does not currently have a unique sprite, and instead just looks like the pocket guide to firearms. This is because I'm too lazy to go in and make a good-looking sprite based on the actual book
I did not bother porting any of the other recipes in the Craftable Gun Pack because I was primarily focused on the Luty.
I am not entirely sure about the itemgroups I put the book in, but figured that putting it in most of the same groups as the pocket guide made enough sense.
Philip Luty's website is still up (despite him being dead of cancer), and actually has PDF versions of most of his books! It's fairly easily found by googling.