Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune unused code #2072

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Prune unused code #2072

merged 4 commits into from
Feb 3, 2025

Conversation

lintool
Copy link
Member

@lintool lintool commented Jan 31, 2025 •
edited
Loading

  • LTR + IRST code (of academic interest but not useful)
  • nmslib bindings + lightgbm (needed by above)
  • deprecated placeholder classes pyserini.dsearch and pyserini.hsearch
  • associated test cases

@lintool lintool marked this pull request as draft January 31, 2025 22:33
@lintool lintool changed the title Prune away LTR, IRST, and other unused code Prune unused code Feb 2, 2025
@lintool lintool marked this pull request as ready for review February 2, 2025 22:03
@lintool lintool requested review from ronakice and MXueguang February 2, 2025 22:04
@lintool
Copy link
Member Author

lintool commented Feb 2, 2025

@ronakice @MXueguang we've removed dead code from pyserini... doing so in anserini also. agreed?

ronakice
ronakice approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@ronakice ronakice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And yes I feel these parts of the codebase are barely used.

MXueguang
MXueguang approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@MXueguang MXueguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lintool lintool merged commit a65b968 into master Feb 3, 2025
@lintool lintool deleted the prune branch February 3, 2025 16:06
@lintool lintool mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronakice ronakice ronakice approved these changes

@MXueguang MXueguang MXueguang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lintool @ronakice @MXueguang