Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test due to upgrade of dependent libs on Apple M processor #1707

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

lintool
Copy link
Member

@lintool lintool commented Nov 7, 2023

Minor tweak to fix this issue:

======================================================================
FAIL: test_msmarco_passage_tct_colbert_bf_d2q_hybrid_otf (test_tct_colbert.TestTctColBert)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/jimmylin/workspace/pyserini/integrations/dense/test_tct_colbert.py", line 108, in test_msmarco_passage_tct_colbert_bf_d2q_hybrid_otf
    self.assertAlmostEqual(score, 0.3647, places=4)
AssertionError: 0.3646 != 0.3647 within 4 places (0.0001000000000000445 difference)

----------------------------------------------------------------------
Ran 33 tests in 31708.497s

Copy link
Member

@ronakice ronakice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@lintool lintool merged commit 12cbb11 into master Nov 7, 2023
@lintool lintool deleted the flaky-test branch November 7, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants