Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate pre-built indexes on initialization #1334

Closed
lintool opened this issue Nov 5, 2022 · 0 comments · Fixed by #1337
Closed

Validate pre-built indexes on initialization #1334

lintool opened this issue Nov 5, 2022 · 0 comments · Fixed by #1337

Comments

@lintool
Copy link
Member

lintool commented Nov 5, 2022

Current workflow for pre-built indexes doesn't actually validate term stats, unless we explicitly run the check script:

python scripts/validate_prebuilt_indexes.py

As a result, some of the stats for recently installed pre-built indexes are wrong.

Fix: we validate pre-built index stats at initialization. This provides a sanity check against corrupt indexes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate pre-built indexes on intialization castorini/pyserini
1 participant
@lintool