Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MS MARCO (V2) regressions for doc2query-T5 #1744

Merged
merged 11 commits into from
Jan 20, 2022
Merged

Add MS MARCO (V2) regressions for doc2query-T5 #1744

merged 11 commits into from
Jan 20, 2022

Conversation

lintool
Copy link
Member

@lintool lintool commented Jan 19, 2022

Closes #1735

@codecov-commenter
Copy link

Codecov Report

Merging #1744 (fb761d6) into master (d7a5d6c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1744   +/-   ##
=========================================
  Coverage     57.58%   57.58%           
  Complexity     1032     1032           
=========================================
  Files           173      173           
  Lines          9781     9781           
  Branches       1344     1344           
=========================================
  Hits           5632     5632           
  Misses         3675     3675           
  Partials        474      474           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a5d6c...fb761d6. Read the comment docs.

Copy link
Member

@ronakice ronakice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Numbers seem to match paper :)

docs/regressions-dl21-doc-segmented-d2q-t5.md Outdated Show resolved Hide resolved
docs/regressions-dl21-passage-augmented-d2q-t5.md Outdated Show resolved Hide resolved
@lintool lintool merged commit 1be47b9 into master Jan 20, 2022
@lintool lintool deleted the d2q branch January 20, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MS MARCO (V2) regressions for docTTTTTquery expansions
3 participants