Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Dropbox links to support direct download #1422

Merged
merged 3 commits into from
Nov 22, 2020
Merged

Conversation

lintool
Copy link
Member

@lintool lintool commented Nov 22, 2020

Adding the suffix ?dl=1 is a Dropbox convention to support direct download without taking you to a landing page.

This makes it possible to check the page with our download scripts:

python scripts/check_download_links.py --url https://raw.githubusercontent.com/castorini/anserini/dropbox-links/docs/experiments-covid.md
python scripts/check_download_links.py --url https://raw.githubusercontent.com/castorini/anserini/dropbox-links/docs/experiments-covid-doc2query.md

@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #1422 (b03f446) into master (558ff2b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1422   +/-   ##
=========================================
  Coverage     54.79%   54.79%           
  Complexity      853      853           
=========================================
  Files           148      148           
  Lines          8595     8595           
  Branches       1218     1218           
=========================================
  Hits           4710     4710           
  Misses         3492     3492           
  Partials        393      393           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 558ff2b...0edc844. Read the comment docs.

Copy link
Member

@rodrigonogueira4 rodrigonogueira4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! I knew I didn't like ?dl=1 for some reason, but I couldn't remember why..

@tteofili
Copy link
Collaborator

+1 (I dislike ?dl=1 too)

@lintool lintool merged commit 746447a into master Nov 22, 2020
@lintool lintool deleted the dropbox-links branch November 22, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants