Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iso19115 indexer, major refactoring and new test cases added #1317

Merged
merged 28 commits into from
Jul 13, 2020

Conversation

shaneding
Copy link
Contributor

No description provided.

shaneding and others added 28 commits June 7, 2020 10:12
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #1317 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1317      +/-   ##
============================================
+ Coverage     51.56%   51.60%   +0.04%     
  Complexity      797      797              
============================================
  Files           154      154              
  Lines          8589     8592       +3     
  Branches       1216     1217       +1     
============================================
+ Hits           4429     4434       +5     
+ Misses         3792     3790       -2     
  Partials        368      368              
Impacted Files Coverage Δ Complexity Δ
...ava/io/anserini/collection/Iso19115Collection.java 75.00% <100.00%> (+2.27%) 2.00 <0.00> (ø)
...java/io/anserini/ltr/feature/CountBigramPairs.java 64.93% <0.00%> (-1.30%) 23.00% <0.00%> (-1.00%)
...anserini/ltr/feature/base/PMIFeatureExtractor.java 86.53% <0.00%> (+1.92%) 13.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b696a0...e4a7d32. Read the comment docs.

@shaneding shaneding changed the title Iso19115 indexer Iso19115 indexer, major refactoring and new test cases added Jul 13, 2020
@lintool lintool self-requested a review July 13, 2020 11:00
@lintool lintool merged commit fad12be into castorini:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants