Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misalignment in SearchCollection and SimpleImpactSearcher implementation #2167

Closed
lintool opened this issue Aug 11, 2023 · 1 comment
Closed

Misalignment in SearchCollection and SimpleImpactSearcher implementation #2167

lintool opened this issue Aug 11, 2023 · 1 comment
Assignees
@AileenLin

Comments

@lintool
Copy link
Member

lintool commented Aug 11, 2023

@AileenLin noticed this while debugging:

SimpleImpactSearcher uses the raw weights to build the Query, but SearchCollection use the encodedQueryString to build Query instead.

We decided that SearchCollection should be the "ground truth".

This manifests in Anserini and Pyserini regression results diverging:

Screen Shot 2023-08-11 at 6 48 21 PM Screen Shot 2023-08-11 at 6 48 14 PM
@lintool lintool mentioned this issue Aug 11, 2023
Merged
lintool pushed a commit that referenced this issue Aug 11, 2023
@AileenLin
Fix misalignment in SearchCollection and SimpleImpactSearcher impleme…
862bd27 
…ntations (#2165) - ref #2167
@lintool
Copy link
Member Author

lintool commented Aug 15, 2023

Closed by #2165

@lintool lintool closed this as completed Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AileenLin AileenLin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lintool @AileenLin