Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Castle.Core to <5.0 to avoid breaking changes #610

Merged
merged 2 commits into from
May 17, 2022

Conversation

Jevonius
Copy link
Contributor

With the release of [email protected], there are a number of breaking changes (for example castleproject/Core#563) that affect Windsor.

Example code that blows up:

var container = new WindsorContainer().Install(FromAssembly.Named("Does.Not.Matter"));

Gives an exceptions along the lines:

System.TypeLoadException : Could not load type 'Castle.Core.Internal.PermissionUtil' from assembly 'Castle.Core, Version=5.0.0.0, Culture=neutral, PublicKeyToken=407dd0808d44fbdc'.

System.TypeLoadException : Could not load type 'Castle.Core.Pair`2' from assembly 'Castle.Core, Version=5.0.0.0, Culture=neutral, PublicKeyToken=407dd0808d44fbdc'.

This PR limits the upper version of Castle.Core to < 5.0, so that these changes don't bite consumers at runtime, until Windsor is updated to support the new version.

Took the opportunity to remove unnecessary references to Castle.Core in Facility projects that transitively include it already by referencing the base Castle.Windsor project.

@jonorossi
Copy link
Member

There are a bunch of unreleased changes in master including some changes to target frameworks:
v5.1.1...master

Let's leave that in master so we can do what's relevant for today, I've created a branch off v5.1.1 to work in.

@jonorossi jonorossi changed the base branch from master to releases/5.1 May 14, 2022 11:55
@jonorossi
Copy link
Member

@Jevonius Your changes look good. Can you rebase off the releases/5.1 branch to remove the changes we don't want to ship.

@jonorossi jonorossi changed the base branch from releases/5.1 to master May 14, 2022 11:57
Jevonius added 2 commits May 14, 2022 19:09
These are covered transitively via the reference to Castle.Windsor base project.
@Jevonius Jevonius force-pushed the limit-core-version branch from 01fef10 to 1cdf0bd Compare May 14, 2022 18:10
@Jevonius Jevonius changed the base branch from master to releases/5.1 May 14, 2022 18:11
@Jevonius
Copy link
Contributor Author

@Jevonius Your changes look good. Can you rebase off the releases/5.1 branch to remove the changes we don't want to ship.

I think I've done this now (haven't done a huge amount of rebasing before).

@jonorossi jonorossi merged commit 1c09b64 into castleproject:releases/5.1 May 17, 2022
@jonorossi jonorossi added this to the v5.1.2 milestone May 17, 2022
@jonorossi jonorossi mentioned this pull request May 17, 2022
@Jevonius Jevonius deleted the limit-core-version branch May 17, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants