-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Castle.Windsor.Extensions.DependencyInjection: support parallel containers (see #563) #577
Castle.Windsor.Extensions.DependencyInjection: support parallel containers (see #563) #577
Conversation
src/Castle.Windsor.Extensions.DependencyInjection/Scope/ExtensionContainerScope.cs
Outdated
Show resolved
Hide resolved
@rvdginste @jonorossi @rvdginste can you give me access to the fork? I have a test to add for this change that tests the muli assembly issues easily. |
5194020
to
4c4a616
Compare
@generik0 I sent you an invite.. not clear whether I still have to give you write access though, just let me know. |
src/Castle.Windsor.Extensions.DependencyInjection/Scope/ExtensionContainerScope.cs
Outdated
Show resolved
Hide resolved
@rvdginste good work. If the tests pass in a bit, then I think this change is good to merge. |
c838b20
to
d46be5b
Compare
src/Castle.Windsor.Extensions.DependencyInjection/WindsorScopeFactory.cs
Outdated
Show resolved
Hide resolved
src/Castle.Windsor.Extensions.DependencyInjection/WindsorScopeFactory.cs
Outdated
Show resolved
Hide resolved
src/Castle.Windsor.Extensions.DependencyInjection/Scope/ExtensionContainerRootScopeAccessor.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rvdginste. I've included some review comments. Could you please also update the changelog.
src/Castle.Windsor.Extensions.DependencyInjection/WindsorScopeFactory.cs
Outdated
Show resolved
Hide resolved
src/Castle.Windsor.Extensions.DependencyInjection/WindsorScopeFactory.cs
Outdated
Show resolved
Hide resolved
src/Castle.Windsor.Extensions.DependencyInjection/Scope/ExtensionContainerScope.cs
Outdated
Show resolved
Hide resolved
src/Castle.Windsor.Extensions.DependencyInjection/Scope/ExtensionContainerScope.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @generik0 for the back and forth on this pull request, I've got a few more review comments on the recent commits.
src/Castle.Windsor.Extensions.DependencyInjection/Scope/ExtensionContainerScope.cs
Outdated
Show resolved
Hide resolved
src/Castle.Windsor.Extensions.DependencyInjection/Scope/ExtensionContainerScope.cs
Outdated
Show resolved
Hide resolved
src/Castle.Windsor.Extensions.DependencyInjection/Scope/ExtensionContainerScopeAccessor.cs
Outdated
Show resolved
Hide resolved
src/Castle.Windsor.Extensions.DependencyInjection/WindsorScopedServiceProvider.cs
Outdated
Show resolved
Hide resolved
src/Castle.Windsor.Extensions.DependencyInjection/WindsorScopedServiceProvider.cs
Show resolved
Hide resolved
src/Castle.Windsor.Extensions.DependencyInjection/Scope/ExtensionContainerScope.cs
Outdated
Show resolved
Hide resolved
src/Castle.Windsor.Extensions.DependencyInjection/WindsorScopedServiceProvider.cs
Show resolved
Hide resolved
…port-parallel-containers
@jonorossi i cleaned up, and improved substitution and single responsibility a bit:
I can revert if you do not feel i have SOLIDfied the Castle.Windsor.Extensions.DependencyInjection more |
src/Castle.Windsor.Extensions.DependencyInjection/Scope/ExtensionContainerScopeBase.cs
Outdated
Show resolved
Hide resolved
src/Castle.Windsor.Extensions.DependencyInjection/Scope/ExtensionContainerScopeAccessor.cs
Outdated
Show resolved
Hide resolved
To fix issue castleproject#563 (support concurrently existing containers) a fix was created in castleproject#577. After the initial fix some refactorings were done on the scope implementation that were not correct. This commit changes the scope implementation back to the original implementation of @ltines, but with the support for concurrent containers.
To fix issue castleproject#563 (support concurrently existing containers) a fix was created in castleproject#577. After the initial fix some refactorings were done on the scope implementation that were not correct. This commit changes the scope implementation back to the original implementation of @ltines, but with the support for concurrent containers.
To fix issue castleproject#563 (support concurrently existing containers) a fix was created in castleproject#577. After the initial fix some refactorings were done on the scope implementation that were not correct. This commit changes the scope implementation back to the original implementation of @ltines, but with the support for concurrent containers.
An attempt to fix the issue in #563.