Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change target framework from .NET Standard 1.6 to 2.0, and move .NET Core tests to .NET 5 #572

Merged
merged 17 commits into from
Dec 10, 2020
Merged

Change target framework from .NET Standard 1.6 to 2.0, and move .NET Core tests to .NET 5 #572

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
9fafb4d
Change frameworks to net45;netstandard2.0;net5.0
generik0 Nov 25, 2020
35ac203
Update testing frameworks
generik0 Nov 26, 2020
3f40dab
Update to Castle.Core 4.4.1
generik0 Nov 29, 2020
beaca14
change 261 to netcoreapp3.1 as it will also test .netstandard sdk
generik0 Nov 29, 2020
caa99c8
Chnage build to only use net5.0, no need for unix longer
generik0 Nov 29, 2020
a43692a
Remove netcoreapp 2.2 from tests as it is no longer needed
generik0 Dec 3, 2020
266fd9a
Remove unneeded BuildScripts project and manually add build scripts t…
generik0 Dec 7, 2020
0c5f13b
Merge remote-tracking branch 'castle.windsor/master' into feature/564…
generik0 Dec 7, 2020
41d7d5e
Test Castle.Windsor with net45 and net5.0
generik0 Dec 7, 2020
9cc5fa1
Build Castle.Windsor with net45 and netstandard2.0
generik0 Dec 7, 2020
d253d3c
Build Castle.Windsor.Extensions.DependencyInjection with netstandard2.0
generik0 Dec 7, 2020
199e5ee
Build Castle.Facilities.Logging with net45;netstandard2.0
generik0 Dec 7, 2020
b3b0494
Test Castle.Windsor.Extensions.DependencyInjection.Tests with net5.0
generik0 Dec 7, 2020
f2ad75f
Clean up package references for netstandard2.0
generik0 Dec 9, 2020
055afbe
Revert Microsoft.Extensions.DependencyModel back to Version="1.1.2"
generik0 Dec 9, 2020
63ea95f
Removed netcoreapp1.0 from Castle.Windsor.Tests
generik0 Dec 9, 2020
34cc9b7
Update Microsoft.Extensions.DependencyModel to Version="2.1.0" in Ca…
generik0 Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions buildscripts/BuildScripts.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,13 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net461;netcoreapp1.1</TargetFrameworks>
<TargetFramework>net5.0</TargetFramework>
jonorossi marked this conversation as resolved.
Show resolved Hide resolved
</PropertyGroup>

<PropertyGroup>
<SignAssembly>False</SignAssembly>
<GeneratePackageOnBuild>False</GeneratePackageOnBuild>
<AssemblyOriginatorKeyFile>CastleKey.snk</AssemblyOriginatorKeyFile>
<FrameworkPathOverride Condition="'$(OS)'=='Unix'AND'$(TargetFramework)'=='net461'">$(NuGetPackageFolders)microsoft.targetingpack.netframework.v4.6.1\1.0.1\lib\net461\</FrameworkPathOverride>
</PropertyGroup>

<ItemGroup>
<PackageReference Condition="'$(OS)'=='Unix'AND'$(TargetFramework)'=='net461'" Include="Microsoft.TargetingPack.NETFramework.v4.6.1" Version="1.0.1" ExcludeAssets="All" PrivateAssets="All" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion src/Castle.Facilities.Logging/Castle.Facilities.Logging.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net45;netstandard1.6</TargetFrameworks>
<TargetFrameworks>net45;netstandard2.0;net5.0</TargetFrameworks>
</PropertyGroup>

<Import Project="..\..\buildscripts\common.props"></Import>
Expand Down
4 changes: 2 additions & 2 deletions src/Castle.Facilities.WcfIntegration.Tests/Castle.Facilities.WcfIntegration.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Castle.Core" Version="4.3.1" />
<PackageReference Include="Castle.Core-log4net" Version="4.3.1" />
<PackageReference Include="Castle.Core" Version="4.4.1" />
<PackageReference Include="Castle.Core-log4net" Version="4.4.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.3.0" />
<PackageReference Include="Microsoft.TestPlatform.ObjectModel" Version="11.0.0" />
<PackageReference Include="NUnit" Version="3.8.1" />
Expand Down
2 changes: 1 addition & 1 deletion ...ions.DependencyInjection.Tests/Castle.Windsor.Extensions.DependencyInjection.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>netcoreapp2.2;netcoreapp3.0;netcoreapp3.1;net461</TargetFrameworks>
<TargetFrameworks>net461;netcoreapp2.2;netcoreapp3.1;net5.0;</TargetFrameworks>

<IsPackable>false</IsPackable>

Expand Down
20 changes: 8 additions & 12 deletions src/Castle.Windsor.Tests/Castle.Windsor.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net45;netcoreapp1.0</TargetFrameworks>
<TargetFrameworks>net45;netcoreapp3.1;net5.0</TargetFrameworks>
</PropertyGroup>

<Import Project="..\..\buildscripts\common.props"></Import>
Expand Down Expand Up @@ -43,23 +43,19 @@
</EmbeddedResource>
</ItemGroup>

<ItemGroup>
<PackageReference Include="NUnit" Version="3.8.1" />
<ItemGroup>
<PackageReference Include="Castle.Core" Version="4.4.1" />
<PackageReference Include="Castle.Core-log4net" Version="4.4.1" />
<PackageReference Include="Castle.Core-NLog" Version="4.4.1" />
<PackageReference Include="NUnit" Version="3.8.1" />
<PackageReference Include="NUnit3TestAdapter" Version="3.8.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.3.0" />
</ItemGroup>
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)'=='net45'">
<PackageReference Include="Castle.Core" Version="4.3.1" />
<PackageReference Include="Castle.Core-log4net" Version="4.3.1" />
<PackageReference Include="Castle.Core-NLog" Version="4.3.1" />
<PackageReference Include="Microsoft.TestPlatform.ObjectModel" Version="11.0.0" />
<PackageReference Include="Microsoft.TestPlatform.ObjectModel" Version="11.0.0" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)'=='netcoreapp1.0'">
<PackageReference Include="System.Reflection.Extensions" Version="4.3.0" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\Castle.Facilities.Logging\Castle.Facilities.Logging.csproj" />
<ProjectReference Include="..\Castle.Windsor\Castle.Windsor.csproj" />
Expand Down
2 changes: 1 addition & 1 deletion src/Castle.Windsor.Tests/CircularDependencyTestCase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public string Path
{
get
{
var uriPath = new Uri(typeof(AssemblyPath).GetTypeInfo().Assembly.CodeBase);
var uriPath = new Uri(typeof(AssemblyPath).GetTypeInfo().Assembly.Location);
return uriPath.LocalPath;
}
}
Expand Down
22 changes: 15 additions & 7 deletions src/Castle.Windsor/Castle.Windsor.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net45;netstandard1.6</TargetFrameworks>
<TargetFrameworks>net45;netstandard2.0;net5.0</TargetFrameworks>
jonorossi marked this conversation as resolved.
Show resolved Hide resolved
</PropertyGroup>

<Import Project="..\..\buildscripts\common.props"></Import>
Expand Down Expand Up @@ -33,10 +33,18 @@
<Reference Include="System.Web" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)'=='netstandard1.6'">
<PackageReference Include="System.Runtime.Serialization.Formatters" Version="4.3.0" />
<PackageReference Include="System.Runtime.Loader" Version="4.3.0" />
<PackageReference Include="System.Threading.Thread" Version="4.3.0" />
<PackageReference Include="Microsoft.Extensions.DependencyModel" Version="1.1.2" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFramework)'=='netstandard2.0' OR '$(TargetFramework)'=='net5.0'">
generik0 marked this conversation as resolved.
Show resolved Hide resolved
<PackageReference Include="System.Runtime.Serialization.Formatters" Version="4.3.0" />
<PackageReference Include="System.Runtime.Loader" Version="4.3.0" />
<PackageReference Include="System.Threading.Thread" Version="4.3.0" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)'=='netstandard2.0'">
<PackageReference Include="Microsoft.Extensions.DependencyModel" Version="2.1.0" />
</ItemGroup>
generik0 marked this conversation as resolved.
Show resolved Hide resolved

<ItemGroup Condition="'$(TargetFramework)'=='net5.0'">
<PackageReference Include="Microsoft.Extensions.DependencyModel" Version="5.0.0" />
</ItemGroup>
generik0 marked this conversation as resolved.
Show resolved Hide resolved

</Project>
11 changes: 5 additions & 6 deletions src/Castle.Windsor/MicroKernel/Lifestyle/Scoped/CallContextLifetimeScope.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,18 +120,17 @@ private static void SetCurrentScope(CallContextLifetimeScope lifetimeScope)
[SecuritySafeCritical]
public static CallContextLifetimeScope ObtainCurrentScope()
{
object scopeKey;
#if FEATURE_REMOTING
var scopeKey = CallContext.LogicalGetData(callContextKey);
scopeKey = CallContext.LogicalGetData(callContextKey);
#else
var scopeKey = asyncLocal.Value;
scopeKey = asyncLocal.Value;
#endif
if (scopeKey == null)
if (!(scopeKey is Guid))
{
return null;
}

CallContextLifetimeScope scope;
allScopes.TryGetValue((Guid)scopeKey, out scope);
allScopes.TryGetValue((Guid)scopeKey, out var scope);
return scope;
}
}
Expand Down