Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should use the container from the method call, not the root container #558

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Should use the container from the method call, not the root container #558

merged 1 commit into from
Oct 8, 2020

Conversation

generik0
Copy link
Contributor

@generik0 generik0 commented Oct 7, 2020

Should use the container from the method call, not the root container

#557

@jonorossi jonorossi added this to the v5.1.0 milestone Oct 8, 2020
jonorossi
jonorossi reviewed Oct 8, 2020
View reviewed changes
Copy link
Member

@jonorossi jonorossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally WindsorServiceProviderFactoryBase feels very fragile, it has virtual functions that expose each implementation detail so you can override whichever bits you'd like, looks like you'd have to read the code of this base class to know what to override.

@jonorossi jonorossi merged commit f08f03d into castleproject:master Oct 8, 2020
@jonorossi jonorossi linked an issue Oct 8, 2020 that may be closed by this pull request
Code error in AddSubSystemToContainer, wrong container #557
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonorossi jonorossi jonorossi left review comments

@robertcoltheart robertcoltheart robertcoltheart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging this pull request may close these issues.

Code error in AddSubSystemToContainer, wrong container
3 participants
@generik0 @jonorossi @robertcoltheart