Update ServiceDescriptorExtensions.cs #553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
twenzel
commented
Oct 5, 2020
twenzel
commented
- Improve performance due to less reflection
- Prevent runtime errors when renaming RegistrationAdapter.FromServiceDescriptor method
- Improve performance due to less reflection - Prevent runtime errors when renaming RegistrationAdapter.FromServiceDescriptor method
|
Nice @twenzel. Thanks |
|
Why not just use a generic type registration? I've raised #555 to consider instead of this. |
jonorossi
requested changes
Oct 6, 2020
src/Castle.Windsor.Extensions.DependencyInjection/Extensions/ServiceDescriptorExtensions.cs
Outdated
Show resolved
Hide resolved
jonorossi
approved these changes
Oct 6, 2020
|
Hi @jonorossi i agree with this change |
|
@jonorossi i did not see changes on #555 and #553 to be mutually exclusive, but I see now that they are. Thanks for pointing this out to me! @twenzel @robertcoltheart thoughs to which PR is best performance-wise? I would think #555 has most potential? |
|
I mean, reflection is always going to be slow. I haven't benchmarked either change to see which is faster though. |
|
@twenzel @robertcoltheart I think we should remove reflections. But that is just an opinion. Maybe you guys can decide? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.