Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASP.NET MVC: Finding the controller should be made in a case insensitive way #480

Merged
merged 3 commits into from
Mar 29, 2019
Merged

ASP.NET MVC: Finding the controller should be made in a case insensitive way #480

merged 3 commits into from
Mar 29, 2019

Conversation

Yitzchok
Copy link
Contributor

This is for AspNetMvcFacility.
When searching for a controller matching the url from the web request we shouldn't care about the case.

jonorossi
jonorossi requested changes Mar 28, 2019
View reviewed changes
Copy link
Member

@jonorossi jonorossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment.

Can you also update the changelog, just add a new "Unreleased" section to the top.

src/Castle.Facilities.AspNet.Mvc/AspNetMvcControllerFactory.cs Outdated Show resolved Hide resolved
@Yitzchok Yitzchok changed the title Finding the controller should be made a case insensitive way Finding the controller should be made in a case insensitive way Mar 28, 2019
@Yitzchok
Copy link
Contributor Author

I added it to the changelog

jonorossi
jonorossi approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@jonorossi jonorossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

@jonorossi jonorossi merged commit 12e7bc1 into castleproject:master Mar 29, 2019
@jonorossi jonorossi added this to the vNext milestone Mar 29, 2019
@jonorossi jonorossi changed the title Finding the controller should be made in a case insensitive way ASP.NET MVC: Finding the controller should be made in a case insensitive way Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonorossi jonorossi jonorossi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Yitzchok @jonorossi