Fixed first-chance HandlerException for optional parameters #450
Conversation
| handler = TryGetHandlerFromKernel(dependency, context); | ||
| } | ||
| catch (HandlerException exception) | ||
| if (!TryGetHandlerFromKernel(dependency, context, out var handler)) |
There was a problem hiding this comment.
The return false case looks almost identical to the handler = null; return true case below it.
There's a potentially a better factoring to indicate which of the two messages should be used?
jnm2
force-pushed
the
kill_first_chance_exceptions
branch
from
6e82f54 to
1f642df
Compare
…wing first-chance exception
jnm2
force-pushed
the
kill_first_chance_exceptions
branch
from
1f642df to
93ce46c
Compare
| { | ||
| handlers = kernel.GetHandlers(dependency.TargetItemType); | ||
| } | ||
| catch (HandlerException) |
There was a problem hiding this comment.
To make this a valid refactoring, we have to be sure that this method can't throw HandlerException indirectly.
If you know that kernel.GetHandlers would not throw HandlerException, we can remove the try. Same for the try above.
There was a problem hiding this comment.
DefaultNamingSubSystem doesn't appear to, however a custom INamingSubSystem or IHandlersFilter may. Sounds like a sensible way to write it.
jnm2
force-pushed
the
kill_first_chance_exceptions
branch
from
93ce46c to
74b1999
Compare
CHANGELOG.md
Outdated
| @@ -33,6 +33,9 @@ Breaking Changes: | |||
| - Changed `IComponentModelBuilder.BuildModel` to use `Arguments` instead of `IDictionary` | |||
| - Changed `ILazyComponentLoader.Load` to use `Arguments` instead of `IDictionary` | |||
|
|
|||
| Bugfixes: | |||
| - Fixed first-chance HandlerException for optional parameters (@jnm2, #450) | |||
There was a problem hiding this comment.
@jnm2 You've added this inside the 5.0.0-beta001 section which has been released.
There was a problem hiding this comment.
Oops, I'm sorry. Fixed!
jnm2
force-pushed
the
kill_first_chance_exceptions
branch
from
74b1999 to
82f86fb
Compare
Fixes #449.