Facility aspnet.systemweb #350

ghost · 2017-10-07T22:42:06Z

We need to close #283.

I will move on to OWIN next.

- Removed build symbol from README.md - Removed build symbol for SYSTEM_WEB - Renamed system web namespace to include product 'AspNet' - Made build pass and updated appveyor deployments - Added some doco's ... - Updated error report to include the new assembly - Added missing package reference to Microsoft.Web.Infrastructure - Added place holder for system web facility, just a copy of the logging facility docs - Added link for system web facility - Added link for system web facility - Added some more notes to docs - Removed per web request from lifestyles docs - Updating installer documentation to not use per web request - Made sure the generic implementation matching strategy does not reference per web request - Adding CHANGELOG.md entry before I forget - Added comment for better testing idea - Bringing documentation into the solution - Found more gubbins that needed moving - A little more shifting - Small refactor - Completed the tests - Ported testfixtures across to new test project, have the old test project compiling - Moved all the code over, and starting to port the tests - Started moving the microkernel lifestyles across for web requests - Generate project stubs for facility

ghost · 2017-10-08T00:01:11Z

src/Castle.Facilities.AspNet.SystemWeb/Lifestyle/PerWebRequestAttribute.cs

@@ -1,4 +1,4 @@
-// Copyright 2004-2012 Castle Project - http://www.castleproject.org/
+// Copyright 2004-2011 Castle Project - http://www.castleproject.org/


Should be 2017...

ghost · 2017-10-08T00:02:04Z

src/Castle.Facilities.AspNet.SystemWeb/Lifestyle/PerWebRequestLifestyleModule.cs

-		///   Returns current request's scope and detaches it from the request context.
-		///   Does not throw if scope or context not present. To be used for disposing of the context.
-		/// </summary>
-		/// <returns></returns>


I really hate XML

ghost · 2017-10-08T00:04:15Z

README.md

@@ -36,7 +36,6 @@ Symbol                              | .NET 4.5           | .NET Standard
 `FEATURE_SECURITY_PERMISSIONS`      | :white_check_mark: | :no_entry_sign:
 `FEATURE_SERIALIZATION`             | :white_check_mark: | :no_entry_sign:
 `FEATURE_SYSTEM_CONFIGURATION`      | :white_check_mark: | :no_entry_sign:
-`FEATURE_SYSTEM_WEB`                | :white_check_mark: | :no_entry_sign:


Hope you are ok with this?

ghost · 2017-10-08T00:05:03Z

buildscripts/common.props

@@ -34,7 +34,7 @@
 	</PropertyGroup>

 	<PropertyGroup Condition="'$(TargetFramework)'=='net45'">
-		<DefineConstants>$(DefineConstants);FEATURE_PERFCOUNTERS;FEATURE_GAC;FEATURE_ISUPPORTINITIALIZE;FEATURE_REMOTING;FEATURE_SECURITY_PERMISSIONS;FEATURE_SYSTEM_WEB;FEATURE_SYSTEM_CONFIGURATION;FEATURE_WINFORMS;FEATURE_SERIALIZATION;FEATURE_URIMEMBERS;FEATURE_GETCALLINGASSEMBLY;FEATURE_APPDOMAIN;FEATURE_CODEDOM;FEATURE_ASSEMBLIES;FEATURE_REFLECTION_METHODBODY;CASTLE_SERVICES_LOGGING;FEATURE_EVENTLOG</DefineConstants>
+		<DefineConstants>$(DefineConstants);FEATURE_PERFCOUNTERS;FEATURE_GAC;FEATURE_ISUPPORTINITIALIZE;FEATURE_REMOTING;FEATURE_SECURITY_PERMISSIONS;FEATURE_SYSTEM_CONFIGURATION;FEATURE_WINFORMS;FEATURE_SERIALIZATION;FEATURE_URIMEMBERS;FEATURE_GETCALLINGASSEMBLY;FEATURE_APPDOMAIN;FEATURE_CODEDOM;FEATURE_ASSEMBLIES;FEATURE_REFLECTION_METHODBODY;CASTLE_SERVICES_LOGGING;FEATURE_EVENTLOG</DefineConstants>


Was kind of hoping we could get rid of this.

ghost · 2017-10-08T00:06:17Z

docs/igenericimplementationmatchingstrategy.md

@@ -7,7 +7,7 @@ Windsor supports so called *open generic components*, that is components that ar
 For example:

 ```csharp
-Container.Register(Component.For(typeof(IRepository<>)).ImplementedBy(typeof(MyRepository<>)).LifestylePerWebRequest());
+Container.Register(Component.For(typeof(IRepository<>)).ImplementedBy(typeof(MyRepository<>)).LifestyleTransient());


Web Requests really did not need to be tied to generics

ghost · 2017-10-08T00:06:43Z

docs/igenericimplementationmatchingstrategy.md

@@ -28,7 +28,7 @@ public class MyRepository<T>: IRepository<T>, IRepository
 }

 // registration
-Container.Register(Component.For(typeof(IRepository<>)).Forward<IRepository>().ImplementedBy(typeof(MyRepository<>)).LifestylePerWebRequest());
+Container.Register(Component.For(typeof(IRepository<>)).Forward<IRepository>().ImplementedBy(typeof(MyRepository<>)).LifestyleTransient());


ghost · 2017-10-08T00:07:27Z

docs/igenericimplementationmatchingstrategy.md

@@ -91,5 +91,5 @@ To instruct Windsor to use your implementation of `IGenericImplementationMatchin
 Container.Register(Component.For(typeof(IRepository<>))
   .Forward<IRepository>()
   .ImplementedBy(typeof(MyRepository<>), new RepositoryGenericCloser())
-   .LifestylePerWebRequest());
+   .LifestyleTransient());


Again. Generics and Web Requests ... not a thing.

ghost · 2017-10-08T00:08:32Z

docs/lifestyles.md

@@ -38,16 +38,6 @@ Container.Register(Component.For<MyTransientComponent>().LifestyleTransient());

 :information_source: **What transients are good for:** Transient lifestyle is a good choice when you want to be in control of instance's lifetime. When you need new instance, with new state every time. Also transient components don't need to be thread safe, unless you explicitly use them in multi-threaded situations. In most applications you'll find that a large percentage of your components will end up as transient.

-### PerWebRequest


Not a thing so I removed it from the main docs concerning lifestyles. We should be using scopes.

ghost · 2017-10-08T00:10:56Z

docs/mvc-tutorial-part-7-lifestyles.md

@@ -16,7 +16,7 @@ That's however as far as we can get for what we want from `ISession`. When it's

 ### The `PerWebRequest` lifestyle

-To change the `ISession` lifestyle to be per web request, we need to specify that in the registration. So we need to change it to the following:
+Please install the `Castle.AspNet.SystemWebFacility` NuGet first. To change the `ISession` lifestyle to be per web request, we need to specify that in the registration. So we need to change it to the following:


I do believe this documentation is super dated. I did the minimum here, but after changing this I think there is a bit of work that needs to happen here to clear out the cruft.

ghost · 2017-10-08T00:13:30Z

src/Castle.Facilities.AspNet.SystemWeb.Tests/PerWebRequestTestCase.cs

+	using NUnit.Framework;
+
+	[TestFixture]
+    public class PerWebRequestTestCase


Boy scout rule, leave the camp cleaner then what you found it.

ghost · 2017-10-08T00:15:05Z

src/Castle.Facilities.AspNet.SystemWeb.Tests/PerWebRequestTestCase.cs

+		    bool wasReleased = false;
+		    object releasedService = null;
+
+			// Would love to create a testing facility for this which we could 'dog food' to clean up our test library in Windsor


Not just me, I think other people are trying to discover this. We should give them a way of doing it. I personally would love to clean up our tests.

ghost · 2017-10-08T00:16:59Z

src/Castle.Facilities.AspNet.SystemWeb/Lifestyle/PerWebRequestAttribute.cs

 	[AttributeUsage(AttributeTargets.Class, AllowMultiple = false)]
-	public sealed class PerWebRequestAttribute : LifestyleAttribute
+	public sealed class PerWebRequestAttribute : ScopedAttribute


Very important. It fits in with the spirit of where the previous commits were going.

ghost · 2017-10-08T20:06:15Z

Closing this out, I have 2 more facilities. One that supports OWIN for web api self host.

ghost · 2017-10-08T21:10:29Z

Please see #351 instead.

ghost changed the title ~~Facilities systemweb~~ Facility aspnet.systemweb Oct 7, 2017

ghost requested a review from jonorossi October 7, 2017 23:55

ghost commented Oct 8, 2017

View reviewed changes

ghost closed this Oct 8, 2017

ghost deleted the facilities-systemweb branch June 22, 2018 00:23

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Facility aspnet.systemweb #350

Facility aspnet.systemweb #350

ghost commented Oct 7, 2017 •

edited by ghost

Loading

ghost Oct 8, 2017

ghost Oct 8, 2017

ghost Oct 8, 2017

ghost Oct 8, 2017

ghost Oct 8, 2017

ghost Oct 8, 2017

ghost Oct 8, 2017

ghost Oct 8, 2017

ghost Oct 8, 2017

ghost Oct 8, 2017

ghost Oct 8, 2017

ghost Oct 8, 2017

ghost commented Oct 8, 2017

ghost commented Oct 8, 2017

		@@ -1,4 +1,4 @@
		// Copyright 2004-2012 Castle Project - http://www.castleproject.org/
		// Copyright 2004-2011 Castle Project - http://www.castleproject.org/

		@@ -38,16 +38,6 @@ Container.Register(Component.For<MyTransientComponent>().LifestyleTransient());

		:information_source: What transients are good for: Transient lifestyle is a good choice when you want to be in control of instance's lifetime. When you need new instance, with new state every time. Also transient components don't need to be thread safe, unless you explicitly use them in multi-threaded situations. In most applications you'll find that a large percentage of your components will end up as transient.

		### PerWebRequest

Facility aspnet.systemweb #350

Facility aspnet.systemweb #350

Conversation

ghost commented Oct 7, 2017 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Oct 8, 2017

ghost commented Oct 8, 2017

ghost commented Oct 7, 2017 •

edited by ghost

Loading