Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typed factory out of order disposal #344

Merged
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
// Copyright 2004-2017 Castle Project - http://www.castleproject.org/
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

namespace CastleTests.Facilities.TypedFactory
{
using System;

using Castle.Facilities.TypedFactory;
using Castle.MicroKernel.Registration;

using NUnit.Framework;

public sealed class TypedFactoryDisposeOrderTestCase : AbstractContainerTestCase
{
protected override void AfterContainerCreated()
{
Container.AddFacility<TypedFactoryFacility>();
}

[Test]
public void Typed_factories_are_not_disposed_before_their_dependents()
{
Container.Register(
Component.For<Dependency>(),
Component.For<Dependent>());

Container.Resolve<Dependent>();
}

public sealed class Dependency : IDisposable
{
private bool isDisposed;

public void Use()
{
if (isDisposed) throw new ObjectDisposedException(nameof(Dependency));
}

public void Dispose()
{
isDisposed = true;
}
}

public sealed class Dependent : IDisposable
{
private readonly Func<Dependency> factory;

public Dependent(Func<Dependency> factory)
{
this.factory = factory;
}

public void Dispose()
{
using (var needed = factory.Invoke())
{
needed.Use();
}
}
}
}
}
2 changes: 1 addition & 1 deletion src/Castle.Windsor/MicroKernel/DefaultKernel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,8 @@ public virtual void Dispose()

DisposeSubKernels();
TerminateFacilities();
DisposeComponentsInstancesWithinTracker();
DisposeHandlers();
DisposeComponentsInstancesWithinTracker();
UnsubscribeFromParentKernel();
}

Expand Down