Forever fix core releases (v5) #330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 12, 2017 17:01
…, this will help in libraries where Castle.Windsor is a transitive dependency and NuGet upgrades cause assembly binding errors.
…get master green again but it will break when we release Castle.Core again, more work to do here.
…eFacilityTestCase. Ignoring this for now, we need to get Castle releases sorted, Core releases break Windsor releases. This takes priority.
ghost
mentioned this pull request
This was referenced Sep 12, 2017
Closing this pull request because of my comment #327 (comment) and #336.
|
|
Reviewing your comments and then will review the PR. No problems! Like where this is going :) |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonorossi
If we merge this and release a new major version of Castle.Windsor before deploying Castle.Core, then we wont ever have to worry about release drama with the "magic strings" in LoggingFacility
The magic strings have been traded out for some new facilities with strong typing and proper NuGet references:
Castle.Facilities.Logging.NLog
Castle.Facilities.Logging.Log4net
This has also highlighted the fact that these are not yet netcore compliant because their respective service counterparts in Castle.Core have not been upgraded yet. This was slightly hidden and not very obvious.
Personally, I am all for smooth releases what do you think?