Fix for issue #146: Performance Counter Instances Never Removed #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenegozi
reviewed
Sep 21, 2016
|
Nice one |
jonorossi
requested changes
Sep 22, 2016
There was a problem hiding this comment.
Thanks @mackenzieajudd, once you fix my comment in the changelog I'll merge it.
| @@ -975,3 +975,5 @@ Beta 1 - 21/jan/2005 | |||
| - Fixed: Remove method | |||
|
|
|||
| - Fixed: Windsor: Proxy for components with (service != impl) | |||
|
|
|||
| - Changed: Performance Counter InstanceLifetime | |||
There was a problem hiding this comment.
Thanks for updating the changelog, however it is sorted with the newest releases at the top. Could you move this to the first line in the file, we add the release line once we ship.
There was a problem hiding this comment.
Woops, moved it to the first line and updated the formatting to match others.
jonorossi
approved these changes
Sep 22, 2016
|
Looks good, fixes #146. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix turned out to be quite simple (thanks @jonorossi for the tips!), the InstanceLifetime of the created PerformanceCounter had to be set to Process. This causes the created performance counter instances to be removed when the process closes.
I also updated performance-counters.md to reflect this.